From: Junio C Hamano <gitster@pobox.com>
To: Glen Choo <chooglen@google.com>
Cc: git@vger.kernel.org, Jade Lovelace <lists@jade.fyi>
Subject: Re: BUG: git config --global --get ITEM ignores ~/.config/git/config when ~/.gitconfig is present
Date: Wed, 15 Feb 2023 08:19:05 -0800 [thread overview]
Message-ID: <xmqqedqq296u.fsf@gitster.g> (raw)
In-Reply-To: <kl6ly1oze7wb.fsf@chooglen-macbookpro.roam.corp.google.com> (Glen Choo's message of "Wed, 15 Feb 2023 14:53:56 +0800")
Glen Choo <chooglen@google.com> writes:
> I mostly agree, except that I think we should leverage the existing
> "ignore" flags in "config_options".
Excellent.
The option, e.g. --system, does not have to translate to "let's see
which file does the option mean, OK, it is /etc/gitconfig so do the
same thing as --file /etc/gitconfig". Instead, we can treat it as
"do the usual config sequence but ignore everything but the system
config". And that would handle a class like --global that can have
more than one input source in a lot more natural way.
Very good.
prev parent reply other threads:[~2023-02-15 16:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 0:39 BUG: git config --global --get ITEM ignores ~/.config/git/config when ~/.gitconfig is present Jade Lovelace
2023-02-11 1:33 ` Junio C Hamano
2023-02-11 1:44 ` Jade Lovelace
2023-02-11 1:56 ` Junio C Hamano
2023-02-11 3:10 ` Junio C Hamano
2023-02-15 6:53 ` Glen Choo
2023-02-15 16:19 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqedqq296u.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=lists@jade.fyi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).