git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Sven Strickroth <email@cs-ware.de>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	git <git@vger.kernel.org>,
	"Robin H. Johnson" <robbat2@gentoo.org>
Subject: Re: [PATCH] submodule: Accept -v for update command
Date: Sun, 18 Dec 2022 10:25:49 +0900	[thread overview]
Message-ID: <xmqqedsxzen6.fsf@gitster.g> (raw)
In-Reply-To: <f805f2da-a7e1-9fde-cc0a-04a30f79c9af@cs-ware.de> (Sven Strickroth's message of "Sat, 10 Dec 2022 14:06:37 +0100")

Sven Strickroth <email@cs-ware.de> writes:

> Subject: Re: [PATCH] submodule: Accept -v for update command
>
> "git pull -v --recurse-submodules" propagates the "-v" to the
> submodule command which did not support "-v" yet.
>
> Commit a56771a668d introduced this regression.
>
> Signed-off-by: Sven Strickroth <email@cs-ware.de>
> ---

This unfortunately fell in the cracks.  Thanks for a few people who
reported the issue this patch tried to fix recently (it is curous
why this regression that is almost 5 years old suddenly started
biting people).

Applying the improvement suggestions given in the review messages to
the other patch to deal with this regression from the "pull" side,
let's explain the commit this way:

    Subject: [PATCH] submodule: accept -v for the update command

    Since a56771a6 (builtin/pull: respect verbosity settings in
    submodules, 2018-01-25), "git pull -v --recurse-submodules"
    propagates the "-v" to the submodule command, but because the
    latter command does not understand the option, it barfs.

    Teach "git submodule update" to accept the option to fix it.

    Signed-off-by: Sven Strickroth <email@cs-ware.de>
    
Thanks.

>  git-submodule.sh | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 9a50f2e912..7f9582d923 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -244,6 +244,9 @@ cmd_update()
>  		-q|--quiet)
>  			quiet=1
>  			;;
> +		-v|--verbose)
> +			quiet=0
> +			;;
>  		--progress)
>  			progress=1
>  			;;

      reply	other threads:[~2022-12-18  1:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24 12:47 git pull --verbose with submodules ends in error message Fink, Mike
2022-11-25 15:56 ` Sven Strickroth
2022-11-30 18:30   ` [PATCH] Don't pass -v to submodule command Sven Strickroth
2022-11-30 19:17     ` Ævar Arnfjörð Bjarmason
2022-12-01  8:32       ` Sven Strickroth
2022-12-01  8:34         ` [PATCH v2] " Sven Strickroth
2022-12-02  0:24       ` [PATCH] " Junio C Hamano
2022-12-10 13:06         ` [PATCH] submodule: Accept -v for update command Sven Strickroth
2022-12-18  1:25           ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqedsxzen6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=email@cs-ware.de \
    --cc=git@vger.kernel.org \
    --cc=robbat2@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).