From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1338C433ED for ; Fri, 16 Apr 2021 22:25:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C29796137D for ; Fri, 16 Apr 2021 22:25:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234898AbhDPWZf (ORCPT ); Fri, 16 Apr 2021 18:25:35 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:64299 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233514AbhDPWZe (ORCPT ); Fri, 16 Apr 2021 18:25:34 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 21012C9804; Fri, 16 Apr 2021 18:25:09 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=SeQDQ/BB9M1C vURRVroYKJMq+5g=; b=ZE8znWk+hotCZGVrwigJZW4OFGjfcMniYnTuQBu5biUk Svt4XYD2r5Xz3W7gpRiYcI4ZW3WH4Yf+WU3RMfjIoDGY6UCdjmsjBP9RKpYDunMC pn7tDPktlU37Q9SDEjIEdUdNHJSSVqolQmyYRnLjEkmZvjvz1Wsfsa8SwzSDnsU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=OOX7iM 1J4qVscAs11BPQ+RzpCeKq/tw+hKgGL+El8d8E1hPye3Oj4up0K6Jzy6qqwVznBX LDn8mD6QoGF5cMrpYbluwvqsRzuYKcbI5DVx4QY8naOaFImUcF//qP2Y9awHLcL2 uTNY+YcjG4OA3c9UcHlj+oqAKemuVt/fuEOxg= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 1804FC9802; Fri, 16 Apr 2021 18:25:09 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 8A76EC9801; Fri, 16 Apr 2021 18:25:08 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: SZEDER =?utf-8?Q?G=C3=A1bor?= Cc: Jeff King , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , git@vger.kernel.org, Emily Shaffer Subject: Re: [PATCH] Makefile: add missing dependencies of 'config-list.h' References: <20200416211807.60811-2-emilyshaffer@google.com> <20210408212915.3060286-1-szeder.dev@gmail.com> <87pmz4ig4o.fsf@evledraar.gmail.com> <20210409212044.GD2947267@szeder.dev> <20210416213356.GR2947267@szeder.dev> Date: Fri, 16 Apr 2021 15:25:07 -0700 In-Reply-To: <20210416213356.GR2947267@szeder.dev> ("SZEDER =?utf-8?Q?G?= =?utf-8?Q?=C3=A1bor=22's?= message of "Fri, 16 Apr 2021 23:33:56 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 99E91128-9F02-11EB-BBF2-74DE23BA3BAF-77302942!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org SZEDER G=C3=A1bor writes: > On Fri, Apr 16, 2021 at 12:03:54PM -0700, Junio C Hamano wrote: >> SZEDER G=C3=A1bor writes: >>=20 >> > On Thu, Apr 08, 2021 at 07:40:41PM -0400, Jeff King wrote: >> ... >> >> I agree it looks like it's moving in the right direction, but I am >> >> slightly puzzled by the existing code. Why do we need to use $(wild= card) >> >> for git*.txt, but not for the others? >> > >> > We don't need $(wildcard) for git*.txt either, because 'make' expand= s >> > wildcards in prerequisites, see e.g.: >> > >> > https://www.gnu.org/software/make/manual/html_node/Wildcard-Exampl= es.html >> > >> > >> > On a related note: all config variables are now listed in >> > Documentation/config/*.txt; Documentation/*config.txt doesn't contai= n >> > any, so that could be removed. >>=20 >> Is it OK for me to keep expecting an update to the patch happen soon? > > No, I think this is a good bugfix patch that stands on its own, and > further cleanups could be done independently on top and should not > block this patch from being merged to master. That's fair. Thanks.