From: Junio C Hamano <gitster@pobox.com> To: Thomas Gummerer <t.gummerer@gmail.com> Cc: git@vger.kernel.org, Son Luong Ngoc <son.luong@booking.com>, Johannes Schindelin <johannes.schindelin@gmx.de>, Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com> Subject: Re: [PATCH v2 2/2] stash: remove the stash.useBuiltin setting Date: Tue, 03 Mar 2020 10:45:26 -0800 [thread overview] Message-ID: <xmqqeeu98egp.fsf@gitster-ct.c.googlers.com> (raw) In-Reply-To: <20200303174613.3557960-2-t.gummerer@gmail.com> Thomas Gummerer <t.gummerer@gmail.com> writes: > + Unused configuration Variable. Used in Git versions 2.22 to s/Variable/variable/; > + 2.26 as an escape hatch to enable the legacy shellscript > + implementation of rebase. Now the built-in rewrite of it in C > + is always used. Setting this will emit a warning, to alert any > + remaining users that setting this now does nothing. I am a bit torn between "just document it here as a stale variable that can safely be removed from your configuration, and do not warn" and what you did here. Even if we warn for a few releases, this entry cannot be removed from the documentation for a lot longer time, if ever, anyway. It's not like having an extra entry that is unused in the configuration file would hurt users, anyway, and it is not obvious that the warning helps more than it disrupts them by bugging users to remove it from their configuration file.
next prev parent reply other threads:[~2020-03-03 18:45 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-24 8:33 Git Rebase: test failing with GIT_TEST_STASH_USE_BUILTIN=false Son Luong Ngoc 2020-02-25 16:57 ` Junio C Hamano [not found] ` <710DB9BA-D134-48E7-8CAB-B8816FED8AB8@booking.com> 2020-03-01 9:59 ` [External] " Son Luong Ngoc 2020-03-01 10:40 ` Son Luong Ngoc 2020-03-02 18:18 ` [PATCH 1/2] stash: get git_stash_config at the top level Thomas Gummerer 2020-03-02 18:19 ` [PATCH 2/2] stash: remove the stash.useBuiltin setting Thomas Gummerer 2020-03-02 21:30 ` Junio C Hamano 2020-03-02 22:21 ` non-regression bug in 'git merge' (really, xdiff/xmerge, I think) Junio C Hamano 2020-03-06 15:48 ` Elijah Newren 2020-03-03 13:33 ` [PATCH 2/2] stash: remove the stash.useBuiltin setting Johannes Schindelin 2020-03-03 16:47 ` Junio C Hamano 2020-03-03 17:36 ` Thomas Gummerer 2020-03-04 16:41 ` Johannes Schindelin [not found] ` <CA+P7+xqVyMnG6FiyL4hngPfEEMi5CKz1qN5Cy1TMMpLg3CmsBw@mail.gmail.com> 2020-03-06 14:11 ` Johannes Schindelin 2020-03-06 17:29 ` Thomas Gummerer 2020-03-03 17:46 ` [PATCH v2 1/2] stash: get git_stash_config at the top level Thomas Gummerer 2020-03-03 17:46 ` [PATCH v2 2/2] stash: remove the stash.useBuiltin setting Thomas Gummerer 2020-03-03 18:45 ` Junio C Hamano [this message] 2020-03-04 11:49 ` Thomas Gummerer 2020-03-04 16:25 ` Junio C Hamano 2020-03-05 17:04 ` Thomas Gummerer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=xmqqeeu98egp.fsf@gitster-ct.c.googlers.com \ --to=gitster@pobox.com \ --cc=git@vger.kernel.org \ --cc=johannes.schindelin@gmx.de \ --cc=son.luong@booking.com \ --cc=t.gummerer@gmail.com \ --cc=ungureanupaulsebastian@gmail.com \ --subject='Re: [PATCH v2 2/2] stash: remove the stash.useBuiltin setting' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).