From: Junio C Hamano <gitster@pobox.com>
To: Carlo Arenas <carenas@gmail.com>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de,
avarab@gmail.com, l.s.r@web.de
Subject: Re: [RFC PATCH v3] grep: treat PCRE2 jit compilation memory error as non fatal
Date: Mon, 05 Aug 2019 13:16:54 -0700 [thread overview]
Message-ID: <xmqqef1zmkp5.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAPUEspjOtzFxDLrQzLLU7+Q6Z6V8P0=qNrH2NrOzL7Q884krrQ@mail.gmail.com> (Carlo Arenas's message of "Sun, 4 Aug 2019 00:43:17 -0700")
Carlo Arenas <carenas@gmail.com> writes:
> * code is suspiciously similar to one[2] that was rejected, but
> hopefully commit message is better
> ...
> [2] https://public-inbox.org/git/20181209230024.43444-3-carenas@gmail.com/
I do not recall ever rejecting that one.
It did not come with a good proposed log message to be accepted
as-is, so I do not find it surprising that I did not pick it up, was
waiting for a new iteration and then everybody forgot about it.
But that is quite different from getting rejected (with the
connotation that "don't attempt this bad idea again, unless the
world changes drastically").
In any case, this round looks a lot more reasoned. I personally do
not think the warning() is a good idea. As I said in the old
discussion, we by default should treat JIT as a mere optimization,
and we should stay out of the way most of the time.
An additional "must have JIT or we will die" [*1*] can be added on
top of this change, if somebody really cares.
Thanks.
[Reference]
*1* https://public-inbox.org/git/87pnu9yekk.fsf@evledraar.gmail.com/
next prev parent reply other threads:[~2019-08-05 20:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 23:54 [RFC PATCH] grep: allow for run time disabling of JIT in PCRE Carlo Marcelo Arenas Belón
2019-07-29 0:09 ` Carlo Arenas
2019-07-29 4:57 ` Junio C Hamano
2019-07-29 5:29 ` Carlo Arenas
2019-07-29 8:55 ` Ævar Arnfjörð Bjarmason
2019-07-29 10:26 ` Carlo Arenas
2019-07-29 12:38 ` Ævar Arnfjörð Bjarmason
2019-07-30 13:01 ` Carlo Arenas
2019-07-29 10:59 ` [RFC PATCH v2] " Carlo Marcelo Arenas Belón
2019-07-29 11:33 ` Carlo Arenas
2019-07-29 15:11 ` René Scharfe
2019-07-29 17:47 ` Junio C Hamano
2019-07-30 0:49 ` Carlo Arenas
2019-07-30 17:55 ` René Scharfe
2019-07-31 12:36 ` Johannes Schindelin
2019-07-31 16:18 ` Junio C Hamano
2019-07-31 12:32 ` Johannes Schindelin
2019-07-31 14:57 ` Ævar Arnfjörð Bjarmason
2019-08-04 0:25 ` Carlo Arenas
2019-08-04 3:14 ` [RFC PATCH v3] grep: treat PCRE2 jit compilation memory error as non fatal Carlo Marcelo Arenas Belón
2019-08-04 7:43 ` Carlo Arenas
2019-08-05 20:16 ` Junio C Hamano [this message]
2019-07-31 12:24 ` [RFC PATCH] grep: allow for run time disabling of JIT in PCRE Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqef1zmkp5.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).