From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, "Martin Ågren" <martin.agren@gmail.com>
Subject: Re: [PATCH 1/2] Documentation: use 8-space tabs with Asciidoctor
Date: Mon, 07 May 2018 12:04:36 +0900 [thread overview]
Message-ID: <xmqqefioqi7v.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180506204226.955739-1-sandals@crustytoothpaste.net> (brian m. carlson's message of "Sun, 6 May 2018 20:42:25 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> Asciidoctor expands tabs at the beginning of a line. However, it does
> not expand them into 8 spaces by default. Since we use 8-space tabs,
> tell Asciidoctor that we want 8 spaces by setting the tabsize attribute.
> This ensures that our ASCII art renders properly.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
> Documentation/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Wonderful. Thanks.
>
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index 6232143cb9..bcd216d96c 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -184,7 +184,7 @@ ASCIIDOC = asciidoctor
> ASCIIDOC_CONF =
> ASCIIDOC_HTML = xhtml5
> ASCIIDOC_DOCBOOK = docbook45
> -ASCIIDOC_EXTRA += -acompat-mode
> +ASCIIDOC_EXTRA += -acompat-mode -atabsize=8
> ASCIIDOC_EXTRA += -I. -rasciidoctor-extensions
> ASCIIDOC_EXTRA += -alitdd='&\#x2d;&\#x2d;'
> DBLATEX_COMMON =
prev parent reply other threads:[~2018-05-07 3:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 21:04 [PATCH] revisions.txt: expand tabs to spaces in diagram Martin Ågren
2018-05-02 4:50 ` Junio C Hamano
2018-05-02 6:20 ` Martin Ågren
2018-05-04 1:52 ` brian m. carlson
2018-05-04 2:32 ` Junio C Hamano
2018-05-06 20:42 ` [PATCH 1/2] Documentation: use 8-space tabs with Asciidoctor brian m. carlson
2018-05-06 20:42 ` [PATCH 2/2] Documentation: render revisions correctly under Asciidoctor brian m. carlson
2018-05-07 4:11 ` Martin Ågren
2018-05-08 1:13 ` brian m. carlson
2018-05-08 18:31 ` Martin Ågren
2018-05-09 0:24 ` brian m. carlson
2018-05-07 3:04 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqefioqi7v.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).