git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: git@vger.kernel.org,  rsbecker@nexbridge.com,  github@seichter.de
Subject: Re: [PATCH 2/3] config.txt: perform some minor reformatting
Date: Thu, 14 Mar 2024 09:22:03 -0700	[thread overview]
Message-ID: <xmqqfrwsyeac.fsf@gitster.g> (raw)
In-Reply-To: <07d0ac0d11b47983d3aa1760fc01ad92@manjaro.org> (Dragan Simic's message of "Thu, 14 Mar 2024 07:20:25 +0100")

Dragan Simic <dsimic@manjaro.org> writes:

>> I was a bit surprised to see such a "preliminary clean-up" step to
>> come before the main change, not after, but separating this from the
>> change to the next paragraph, which is the main change in this series,
>> is nevertheless a very good idea.
>
> The reason why this patch went as the second in the series was simply
> because it's a somewhat unrelated cleanup that performs no actual
> changes
> to the contents of the documentation.

It would have been understandable if it were left at the end, as
"after the dust settles".  It would made even more sense if it were
at the front, "before doing anything else, let's clean up the
mess--we do not intend to change the behaviour with this change at
all".  Having it in the middle was what made me surprised.

Generally, the order of preference is to do "preliminary clean-up"
first, followed by the real change.  That way, trivial clean-up that
is designed not to change any behaviour can go ahead and merged down
even before the real change solidifies.

Unrelated changes has no place in a series with a real purpose.
Unless the series is about "assorted clean-ups that are not related
with each other", that is.

Thanks.



  reply	other threads:[~2024-03-14 16:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12 15:55 [PATCH 0/3] Improve the documentation and test coverage for whitespace and comments Dragan Simic
2024-03-12 15:55 ` [PATCH 1/3] config.txt: describe whitespace characters further and more accurately Dragan Simic
2024-03-14  1:18   ` Junio C Hamano
2024-03-14  6:20     ` Dragan Simic
2024-03-14 16:45       ` Junio C Hamano
2024-03-14 18:48         ` Dragan Simic
2024-03-12 15:55 ` [PATCH 2/3] config.txt: perform some minor reformatting Dragan Simic
2024-03-14  1:58   ` Junio C Hamano
2024-03-14  6:20     ` Dragan Simic
2024-03-14 16:22       ` Junio C Hamano [this message]
2024-03-14 18:40         ` Dragan Simic
2024-03-12 15:55 ` [PATCH 3/3] t1300: add tests for internal whitespace and inline comments Dragan Simic
2024-03-14  2:18   ` Junio C Hamano
2024-03-14  6:20     ` Dragan Simic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfrwsyeac.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dsimic@manjaro.org \
    --cc=git@vger.kernel.org \
    --cc=github@seichter.de \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).