From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Derrick Stolee" <stolee@gmail.com>,
"René Scharfe" <l.s.r@web.de>
Subject: Re: [PATCH v2 0/7] Speed up mirror-fetches with many refs
Date: Tue, 24 Aug 2021 15:48:19 -0700 [thread overview]
Message-ID: <xmqqfsuylarw.fsf@gitster.g> (raw)
In-Reply-To: cover.1629800774.git.ps@pks.im
Patrick Steinhardt <ps@pks.im> writes:
> this is the second version of my patch series to speed up mirror-fetches
> with many refs. This topic applies on top of Junio's 9d5700f60b (Merge
> branch 'ps/connectivity-optim' into jch, 2021-08-23).
It is a horrible commit to base anything on. You are taking your
patches hostage to all of these other topics.
9d5700f60b Merge branch 'ps/connectivity-optim' into jch
7ad315de2f Merge branch 'js/log-protocol-version' into jch
1726f748f5 Merge branch 'en/ort-becomes-the-default' into jch
23aeecb099 Merge branch 'en/merge-strategy-docs' into jch
568277d458 Merge branch 'en/pull-conflicting-options' into jch
2b316bb006 ### match next
4efa9ea0b6 Merge branch 'ps/fetch-pack-load-refs-optim' into jch
b305842ee8 Merge branch 'jt/push-negotiation-fixes' into jch
83b45616f1 Merge branch 'es/trace2-log-parent-process-name' into jch
be89aa8c38 Merge branch 'hn/refs-test-cleanup' into jch
256d56ed32 Merge branch 'en/ort-perf-batch-15' into jch
7477fbf53a Merge branch 'js/expand-runtime-prefix' into jch
b1453dfd30 Merge branch 'ab/bundle-doc' into jch
1b66e8e89d Merge branch 'zh/ref-filter-raw-data' into jch
1fbf27ddcd Merge branch 'ab/pack-stdin-packs-fix' into jch
dcf57bfebb Merge branch 'ab/http-drop-old-curl' into jch
93041f7c57 Merge branch 'ds/add-with-sparse-index' into jch
814a016195 Merge branch 'jc/bisect-sans-show-branch' into jch
A better way to handle a situation like this is to limit your
dependencies more explicitly. If you look at what I did to the last
round of this topic, you'll see that there is a merge of the
'ps/connectivity-optim' topic into v2.33 followed by application of
the patches, like this:
1d576ca7b2 fetch: avoid second connectivity check if we already have all objects
6768595f10 fetch: refactor fetch refs to be more extendable
a615d7cf87 fetch-pack: optimize loading of refs via commit graph
bfd04fc24c connected: refactor iterator to return next object ID directly
1a387c9f3a fetch: avoid unpacking headers in object existence check
f1a4367ec4 fetch: speed up lookup of want refs via commit-graph
3628199d4d Merge branch 'ps/connectivity-optim' into ps/fetch-optim
What I did to your last round was to merge 'ps/connectivity-optim'
on top of v2.33 and then queue them. You can do the same for this
round (you can tell people "apply these on top of the result of
merging topic X, Y and Z on tag V").
df52ef2c3a fetch: avoid second connectivity check if we already have all objects
c1721680e4 fetch: merge fetching and consuming refs
5470cbe1be fetch: refactor fetch refs to be more extendable
016a510428 fetch-pack: optimize loading of refs via commit graph
f6c7e63cc7 connected: refactor iterator to return next object ID directly
17c8e90df3 fetch: avoid unpacking headers in object existence check
a54c245004 fetch: speed up lookup of want refs via commit-graph
3628199d4d Merge branch 'ps/connectivity-optim' into ps/fetch-optim
I had to adjust [4/7] while applying them on top of the same
3628199d4d I created for queuing the previous round, and it would be
appreciated if you can double-check the result.
Thanks.
next prev parent reply other threads:[~2021-08-24 22:48 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 10:08 [PATCH 0/6] Speed up mirror-fetches with many refs Patrick Steinhardt
2021-08-20 10:08 ` [PATCH 1/6] fetch: speed up lookup of want refs via commit-graph Patrick Steinhardt
2021-08-20 14:27 ` Derrick Stolee
2021-08-20 17:18 ` Junio C Hamano
2021-08-23 6:46 ` Patrick Steinhardt
2021-08-25 14:12 ` Derrick Stolee
2021-08-20 10:08 ` [PATCH 2/6] fetch: avoid unpacking headers in object existence check Patrick Steinhardt
2021-08-25 23:44 ` Ævar Arnfjörð Bjarmason
2021-08-20 10:08 ` [PATCH 3/6] connected: refactor iterator to return next object ID directly Patrick Steinhardt
2021-08-20 14:32 ` Derrick Stolee
2021-08-20 17:43 ` Junio C Hamano
2021-08-20 17:43 ` René Scharfe
2021-08-23 6:47 ` Patrick Steinhardt
2021-08-20 10:08 ` [PATCH 4/6] fetch-pack: optimize loading of refs via commit graph Patrick Steinhardt
2021-08-20 14:37 ` Derrick Stolee
2021-08-20 10:08 ` [PATCH 5/6] fetch: refactor fetch refs to be more extendable Patrick Steinhardt
2021-08-20 14:41 ` Derrick Stolee
2021-08-20 10:08 ` [PATCH 6/6] fetch: avoid second connectivity check if we already have all objects Patrick Steinhardt
2021-08-20 14:47 ` Derrick Stolee
2021-08-23 6:52 ` Patrick Steinhardt
2021-08-20 14:50 ` [PATCH 0/6] Speed up mirror-fetches with many refs Derrick Stolee
2021-08-21 0:09 ` Junio C Hamano
2021-08-24 10:36 ` [PATCH v2 0/7] " Patrick Steinhardt
2021-08-24 10:36 ` [PATCH v2 1/7] fetch: speed up lookup of want refs via commit-graph Patrick Steinhardt
2021-08-25 14:16 ` Derrick Stolee
2021-08-24 10:37 ` [PATCH v2 2/7] fetch: avoid unpacking headers in object existence check Patrick Steinhardt
2021-08-24 10:37 ` [PATCH v2 3/7] connected: refactor iterator to return next object ID directly Patrick Steinhardt
2021-08-24 10:37 ` [PATCH v2 4/7] fetch-pack: optimize loading of refs via commit graph Patrick Steinhardt
2021-08-24 10:37 ` [PATCH v2 5/7] fetch: refactor fetch refs to be more extendable Patrick Steinhardt
2021-08-25 14:19 ` Derrick Stolee
2021-09-01 12:48 ` Patrick Steinhardt
2021-08-24 10:37 ` [PATCH v2 6/7] fetch: merge fetching and consuming refs Patrick Steinhardt
2021-08-25 14:26 ` Derrick Stolee
2021-09-01 12:49 ` Patrick Steinhardt
2021-08-24 10:37 ` [PATCH v2 7/7] fetch: avoid second connectivity check if we already have all objects Patrick Steinhardt
2021-08-24 22:48 ` Junio C Hamano [this message]
2021-08-25 6:04 ` [PATCH v2 0/7] Speed up mirror-fetches with many refs Patrick Steinhardt
2021-08-25 14:27 ` Derrick Stolee
2021-09-01 13:09 ` [PATCH v3 " Patrick Steinhardt
2021-09-01 13:09 ` [PATCH v3 1/7] fetch: speed up lookup of want refs via commit-graph Patrick Steinhardt
2021-09-01 13:09 ` [PATCH v3 2/7] fetch: avoid unpacking headers in object existence check Patrick Steinhardt
2021-09-01 13:09 ` [PATCH v3 3/7] connected: refactor iterator to return next object ID directly Patrick Steinhardt
2021-09-01 13:09 ` [PATCH v3 4/7] fetch-pack: optimize loading of refs via commit graph Patrick Steinhardt
2021-09-01 13:09 ` [PATCH v3 5/7] fetch: refactor fetch refs to be more extendable Patrick Steinhardt
2021-09-01 13:10 ` [PATCH v3 6/7] fetch: merge fetching and consuming refs Patrick Steinhardt
2021-09-01 13:10 ` [PATCH v3 7/7] fetch: avoid second connectivity check if we already have all objects Patrick Steinhardt
2021-09-01 19:58 ` [PATCH v3 0/7] Speed up mirror-fetches with many refs Junio C Hamano
2021-09-08 0:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfsuylarw.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).