From: Junio C Hamano <gitster@pobox.com>
To: "Miriam R." <mirucam@gmail.com>
Cc: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
git <git@vger.kernel.org>,
"Rafael Silva" <rafaeloliveira.cs@gmail.com>
Subject: Re: What's cooking in git.git (Jan 2021, #06; Sat, 30)
Date: Wed, 03 Feb 2021 17:38:26 -0800 [thread overview]
Message-ID: <xmqqft2ca9yl.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAN7CjDC8dy4Kp=rD4rSu5pnxUAWQ=GyXmU98BsiL84H2XKbbXA@mail.gmail.com> (Miriam R.'s message of "Wed, 3 Feb 2021 23:00:25 +0100")
"Miriam R." <mirucam@gmail.com> writes:
>> > I think the bisect_log still haven't added back the:
>> >
>> > We are not bisecting
>> >
>> > as addressing in gohp6kv9bml9qc.fsf@gmail.com
>>
>> OK, I'll put it on hold and wait for a proper fix-up patch.
>>
> I have just sent the new patch series version with this and other minor fixes.
> Best,
> Miriam.
Thanks for a quick turnaround. Queued and pushed out.
I think the change, especially to the first one, covers the above
comment sufficiently.
1: 7766d1f8a8 ! 1: 97d5ba6a39 bisect--helper: reimplement `bisect_log` shell function in C
@@ Commit message
Mentored-by: Lars Schneider <larsxschneider@gmail.com>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
+ Helped-by: Rafael Silva <rafaeloliveira.cs@gmail.com>
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
@@ builtin/bisect--helper.c: static enum bisect_error bisect_state(struct bisect_te
+static enum bisect_error bisect_log(void)
+{
+ int fd, status;
-+ fd = open(git_path_bisect_log(), O_RDONLY);
++ const char* filename = git_path_bisect_log();
++
++ if (is_empty_or_missing_file(filename))
++ return error(_("We are not bisecting."));
++
++ fd = open(filename, O_RDONLY);
+ if (fd < 0)
+ return BISECT_FAILED;
+
prev parent reply other threads:[~2021-02-04 1:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 0:00 What's cooking in git.git (Jan 2021, #06; Sat, 30) Junio C Hamano
2021-01-31 1:42 ` Taylor Blau
2021-01-31 20:50 ` Junio C Hamano
2021-01-31 17:21 ` SZEDER Gábor
2021-01-31 20:52 ` Junio C Hamano
2021-01-31 20:11 ` Derrick Stolee
2021-01-31 20:53 ` Junio C Hamano
2021-02-01 0:27 ` Ævar Arnfjörð Bjarmason
2021-02-01 1:48 ` Junio C Hamano
2021-02-02 15:54 ` Johannes Schindelin
2021-02-02 20:18 ` Junio C Hamano
2021-02-01 15:51 ` Charvi Mendiratta
2021-02-01 19:48 ` Junio C Hamano
2021-02-02 15:28 ` Charvi Mendiratta
2021-02-03 1:08 ` Đoàn Trần Công Danh
2021-02-03 1:22 ` Junio C Hamano
2021-02-03 22:00 ` Miriam R.
2021-02-04 1:38 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqft2ca9yl.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=mirucam@gmail.com \
--cc=rafaeloliveira.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).