From: Junio C Hamano <email@example.com> To: Jeff King <firstname.lastname@example.org> Cc: Philippe Blain <email@example.com>, "Bradley M. Kuhn" <firstname.lastname@example.org>, Git mailing list <email@example.com> Subject: Re: [PATCH 0/1] Clarify and expand description of --signoff Date: Thu, 15 Oct 2020 19:30:34 -0700 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20201016015937.GA3335046@coredump.intra.peff.net> (Jeff King's message of "Thu, 15 Oct 2020 21:59:37 -0400") Jeff King <email@example.com> writes: > We do already say pretty clearly what signed-off-by means in the > project: > > $ grep -A14 '\[\[sign-off]]' Documentation/SubmittingPatches > [[sign-off]] > === Certify your work by adding your "Signed-off-by: " line > > To improve tracking of who did what, we've borrowed the > "sign-off" procedure from the Linux kernel project on patches > that are being emailed around. Although core Git is a lot > smaller project it is a good discipline to follow it. > > The sign-off is a simple line at the end of the explanation for > the patch, which certifies that you wrote it or otherwise have > the right to pass it on as an open-source patch. The rules are > pretty simple: if you can certify the below D-C-O: > > [[dco]] > .Developer's Certificate of Origin 1.1 > > What should we change there? We could perhaps bring up signoffs earlier > or more prominently. Or tie it in to the git-commit docs by saying > explicitly: these are _our_ project rules for signoffs. That is almost good enough, but you can easily see that it was written back when the world only had choice between "Linux-style signed-off-by that means Linux-style DCO requirement" and "not signing off", and we chose to be in the former camp. I think the most important clarification Bradley's making is that we no longer live in such a world. "signed-off-by" means different things for different projects, and what we use is this one. That choice may have been adopted from the Linux project and may have been identical to what they used back when we adopted it, but that is of secondary importance (most importantly, if they changed what it means, that won't directly affect this project). Perhaps I'd rewrite these two paragraphs like so: To improve tracking of who did what, we use the "sign off" procedure. By adding the "Signed-off-by:" line in the trailer of your commit, you certify to this project the below D-C-O that you have the right to pass your patch on under the same license as ours. Without such a sign-off, we cannot accept your patch: [[dco]] .Developer's Certificate of Origin 1.1 ... and after the DCO text, add this paragraph as a historical reference. This procedure originally came from the Linux kernel project, so our rule is quite similar to theirs, but what exactly it means to sign-off your patch differs from project to project, so it may be different from that of the project you are accustomed to. either before or after the "Random J Developer" example. I think we should remove the "you can do this automatically by giving -s" or at least the word "automatically" from that sentence, while we are at it. Thanks.
next prev parent reply index Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-15 21:59 Bradley M. Kuhn 2020-10-15 21:59 ` [PATCH 1/1] Documentation: " Bradley M. Kuhn 2020-10-16 0:46 ` Jeff King 2020-10-18 15:13 ` Theodore Y. Ts'o 2020-10-16 1:49 ` [PATCH 0/1] " Philippe Blain 2020-10-16 1:54 ` Junio C Hamano 2020-10-16 1:59 ` Jeff King 2020-10-16 2:30 ` Junio C Hamano [this message] 2020-10-16 19:53 ` Junio C Hamano 2020-10-16 20:11 ` Jeff King 2020-10-17 3:00 ` Bradley M. Kuhn 2020-10-18 19:08 ` Junio C Hamano 2020-10-19 15:53 ` Theodore Y. Ts'o 2020-10-19 18:26 ` Junio C Hamano 2020-10-19 21:25 ` [PATCH v2 0/3] clarify and expand description of --signoff & related fixes Bradley M. Kuhn 2020-10-19 21:25 ` [PATCH v2 1/3] Documentation: clarify and expand description of --signoff Bradley M. Kuhn 2020-10-19 21:25 ` [PATCH v2 2/3] Documentation: stylistically normalize references to Signed-off-by: Bradley M. Kuhn 2020-10-19 22:02 ` Taylor Blau 2020-10-19 22:17 ` Junio C Hamano 2020-10-20 2:31 ` Taylor Blau 2020-10-20 1:03 ` [PATCH v3 0/4] clarify meaning of --signoff & related doc improvements in describing Signed-off-by Bradley M. Kuhn 2020-10-20 1:03 ` [PATCH v3 1/4] doc: preparatory clean-up of description on the sign-off option Bradley M. Kuhn 2020-10-20 1:03 ` [PATCH v3 2/4] Documentation: clarify and expand description of --signoff Bradley M. Kuhn 2020-10-20 21:44 ` Bradley M. Kuhn 2020-10-20 21:48 ` Taylor Blau 2020-10-20 1:03 ` [PATCH v3 3/4] SubmittingPatches: clarify DCO is our --signoff rule Bradley M. Kuhn 2020-10-20 1:03 ` [PATCH v3 4/4] Documentation: stylistically normalize references to Signed-off-by: Bradley M. Kuhn 2020-10-20 18:52 ` Junio C Hamano 2020-10-20 21:33 ` Bradley M. Kuhn 2020-10-20 2:34 ` [PATCH v3 0/4] clarify meaning of --signoff & related doc improvements in describing Signed-off-by Taylor Blau 2020-10-20 21:28 ` Bradley M. Kuhn 2020-10-20 21:48 ` Taylor Blau 2020-10-20 22:06 ` Junio C Hamano 2020-10-20 23:02 ` Bradley M. Kuhn 2020-10-19 21:25 ` [PATCH v2 3/3] SubmittingPatches: clarify DCO is our --signoff rule Bradley M. Kuhn 2020-10-18 19:49 [PATCH v2 0/3] Claryfing the meaning of the sign-off Junio C Hamano 2020-10-18 19:49 ` [PATCH v2 1/3] doc: preparatory clean-up of description on the sign-off option Junio C Hamano 2020-10-18 19:49 ` [PATCH v2 2/3] Documentation: clarify and expand description of --signoff Junio C Hamano 2020-10-18 19:49 ` [PATCH v2 3/3] SubmittingPatches: clarify DCO is our --signoff rule Junio C Hamano 2020-10-18 23:31 ` [PATCH v2 0/3] Claryfing the meaning of the sign-off Taylor Blau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Mailing List Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/git/0 git/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 git git/ https://lore.kernel.org/git \ firstname.lastname@example.org public-inbox-index git Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git