git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Shulhan <m.shulhan@gmail.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, Wink Saville <wink@saville.com>
Subject: Re: [PATCH 0/1] git-rebase--interactive.sh: fix trailing spaces on empty $todo
Date: Thu, 20 Sep 2018 07:12:47 -0700	[thread overview]
Message-ID: <xmqqfty42r6o.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180918134412.32766-1-m.shulhan@gmail.com> (Shulhan's message of "Tue, 18 Sep 2018 20:44:10 +0700")

Shulhan <m.shulhan@gmail.com> writes:

> For someone who use editor that display trailing white spaces, issuing
> interactive rebase will print two empty lines at the end of rebase with the
> last line contains tab,
>
>   #	However, if you remove everything, the rebase will be aborted.
>   #
>   #\t
>   # Note that empty commits are commented out
>
> The character "\t" in above example is white space tab.
>
> The "make test" was run succesfully but I can't reproduce/test manually with
> non-empty $todo (I have no idea how to do it).

While the issue may still be there, I think that the mid-term plan
for the release after this cycle is to use the GSoC version of
"rebase -i" that rewrites all the logic that produces the above in
C, which has been cooking in 'pu', and hopefully we can see it or
its reroll in 'next' soonish.

So please see if the issue is there, or if you find other new issues
(as this is essentially an attempted faithful re-implementation), in
the version on 'pu', and report/fix them in there if necessary.

Thanks.

> Shulhan (1):
>   git-rebase--interactive.sh: fix trailing spaces on empty $todo
>
>  git-rebase--interactive.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

      parent reply	other threads:[~2018-09-20 14:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18 13:44 [PATCH 0/1] git-rebase--interactive.sh: fix trailing spaces on empty $todo Shulhan
2018-09-18 13:44 ` [PATCH 1/1] " Shulhan
2018-09-20 14:12 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfty42r6o.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=m.shulhan@gmail.com \
    --cc=wink@saville.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).