git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Rose via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Seija Kijin <doremylover123@gmail.com>
Subject: Re: [PATCH] git: remove unneeded casts
Date: Thu, 15 Dec 2022 08:49:45 +0900	[thread overview]
Message-ID: <xmqqh6xxv946.fsf@gitster.g> (raw)
In-Reply-To: <Y5o9NNVx7dFLhIMd@coredump.intra.peff.net> (Jeff King's message of "Wed, 14 Dec 2022 16:16:36 -0500")

Jeff King <peff@peff.net> writes:

> I'll stop here for now. It's a fair bit of leg-work digging
> these up (though again, I do think there's value in
> understanding why the cast was there, even if we know it
> isn't _currently_ doing anything).

I agree with the value of understanding why each of these casts has
become unnecessary, and thanks for demonstrating how a rerolled
version should justify its changes with its findings behind each of
the unnecessary casts.

What do you recommend the next round should look like?  Multi patch
series, each of which removes one cast with its proposed log message
explains how it has become unneeded?  A single patch with a gigantic
proposed log message that lists the findings for each and all casts
that are removed?  Somewhere in between, perhaps split along the
file boundary, or grouped by the event that made them unneeded
(e.g. "cmd_main() used to take non-const but when we made it to take
const, all of these casts we remove in this patch became unneeded")?

Thanks.




  reply	other threads:[~2022-12-14 23:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 15:35 [PATCH] git: remove unneeded casts Rose via GitGitGadget
2022-12-14 21:16 ` Jeff King
2022-12-14 23:49   ` Junio C Hamano [this message]
2022-12-17 13:32     ` Jeff King
2022-12-19  1:07       ` Junio C Hamano
2022-12-15 10:07   ` Ævar Arnfjörð Bjarmason
2022-12-17 13:55     ` Jeff King
2022-12-15 10:18 ` Phillip Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh6xxv946.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=doremylover123@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).