From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Jeff King <peff@peff.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
"Neeraj K. Singh" <neerajsi@microsoft.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Eric Wong <e@80x24.org>, Christoph Hellwig <hch@lst.de>,
Emily Shaffer <emilyshaffer@google.com>
Subject: Re: RFC: A configuration design for future-proofing fsync() configuration
Date: Thu, 11 Nov 2021 10:03:10 -0800 [thread overview]
Message-ID: <xmqqh7cimuxt.fsf@gitster.g> (raw)
In-Reply-To: <211110.86r1bogg27.gmgdl@evledraar.gmail.com> (=?utf-8?B?IsOG?= =?utf-8?B?dmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Wed, 10 Nov 2021 16:09:33 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Continuing a discussion from [1] currently we have:
>
> ; Defaults to 'false'
> core.fsyncObjectFiles = [true|false]
>
> In master..next this has been extended to this by Neeraj:
>
> core.fsyncObjectFiles = [true|false|batch]
>
> Which, as an aside I hadn't considered before and I think we need to
> change before it lands on "master", we really don't want config users
> want to enable that makes older versions hard die. It's annoying to want
> to configure a new thing and not being able to put it in .gitconfig
> because older versions die on it:
>
> $ git -c core.fsyncObjectFiles=batch status; echo $?
> fatal: bad boolean config value 'batch' for 'core.fsyncobjectfiles'
> 128
But then it is also annoying to find out that the shiny new toy you
thought you configured silently is not kicking in. I actually think
Neeraj's "if you are in a mixed environment, you need to be aware of
which copies of Git you use are prepared to use it" would be better
for end users.
For us Git developers, it would be less convenient, though.
prev parent reply other threads:[~2021-11-11 18:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 15:09 RFC: A configuration design for future-proofing fsync() configuration Ævar Arnfjörð Bjarmason
2021-11-11 0:47 ` Neeraj Singh
2021-11-11 0:57 ` Ævar Arnfjörð Bjarmason
2021-11-17 22:16 ` Neeraj Singh
2021-11-18 19:00 ` Junio C Hamano
2021-11-18 19:46 ` Neeraj Singh
2021-11-12 5:54 ` Christoph Hellwig
2021-11-17 18:49 ` Neeraj Singh
2021-11-11 18:03 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh7cimuxt.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=e@80x24.org \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=hch@lst.de \
--cc=neerajsi@microsoft.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).