From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98CADC4361B for ; Tue, 15 Dec 2020 22:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5562B2246B for ; Tue, 15 Dec 2020 22:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729675AbgLOWKh (ORCPT ); Tue, 15 Dec 2020 17:10:37 -0500 Received: from pb-smtp21.pobox.com ([173.228.157.53]:51312 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727841AbgLOWJv (ORCPT ); Tue, 15 Dec 2020 17:09:51 -0500 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 284CAF3F46; Tue, 15 Dec 2020 17:09:09 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=vZ7GJ8q130SSo8wBF8b6MVkvF08=; b=k4c2xN xly+eqDmKbxqpkFvsUwpFQu+RKfKOdAddKHhLDiKEs9lJsYGmIJpsiJLXR/NXB7+ 9qZvuHBE6r9JptGw2kPfpeZB1MM2zlnaZOoUNx4SX9OEUfBjUACvGNIip6Z4eNzw 4NTJ0RvhDl3DTaRgo/8duWcu9FHfU8rsg3YGA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=L3WRPdw2+lNiJD5t/hMCAGaE0Y6iEFof RAPHRAAh7PA/ROXLw6lxYX3bbSz9Vh2DlccfMyxvZAYXBszT/ATeQw607nX2uroZ GDKSw4ADeKGyrKaUkI5XNRPfHttnWwY3Qhn1TAmkrXsP1f9pqsQQBkuv5XYWeG38 HGzMAoJX76A= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 209B2F3F43; Tue, 15 Dec 2020 17:09:09 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.196.173.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 19EB4F3F42; Tue, 15 Dec 2020 17:09:05 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Derrick Stolee Cc: Elijah Newren via GitGitGadget , git@vger.kernel.org, Elijah Newren , Johannes Schindelin Subject: Re: [PATCH v2 00/11] merge-ort: add basic rename detection References: <6448806f-791b-610a-06de-7be5650334e6@gmail.com> Date: Tue, 15 Dec 2020 14:09:03 -0800 In-Reply-To: <6448806f-791b-610a-06de-7be5650334e6@gmail.com> (Derrick Stolee's message of "Tue, 15 Dec 2020 09:34:01 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 253E399C-3F22-11EB-A1EB-D609E328BF65-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Derrick Stolee writes: > On 12/14/2020 11:21 AM, Elijah Newren via GitGitGadget wrote: >> This series builds on en/merge-ort-2 and adds basic rename detection to >> merge-ort. > > I have now finished a full pass through this series. I find it to be > well organized with a satisfying conclusion. My comments are mostly > about nits. I tried to recommend some better organization, but failed > to find a clear way to do so, which shows that the organization here > is sound. > > My only complaint is that some of the patches break compilation, so > that should definitely be fixed to assist with bisects in the future > (likely for bisects unrelated to this feature). Thanks.