From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10DB9C2BA19 for ; Tue, 21 Apr 2020 23:06:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B92B62072D for ; Tue, 21 Apr 2020 23:06:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="xdGBJyAg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726055AbgDUXG1 (ORCPT ); Tue, 21 Apr 2020 19:06:27 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:64058 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725822AbgDUXG1 (ORCPT ); Tue, 21 Apr 2020 19:06:27 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id EEAD154BDB; Tue, 21 Apr 2020 19:06:24 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=U/nAARRjggbNg51C+jpyDB68aZg=; b=xdGBJy Ag4ELrua4fN28cjURHsm6riYI5z+BoP0+m238JB4Xk0Rs25pI8GWfAFWJVHFc4JI /gOEN2M19ME0XSNaxxUhwxZ1iYAv65flixaB633BkQAvLardiLCQx088GxW3R3GY 2PW8F7ru8kTrcsfMs5Lqk6sBAzmi+ZxUWA7To= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=NqJRn7c/wjQcqkaYSS9pOpkcrLDSGgcU EkEerln/FjwWmqF6Uulw4bjwfygI/UoLmLheNdcRE1yN8SWkgDJ+xUhxiR5wt/1H fptKVnwARX3rxfbfakcROsU9aByVW5Jh2rbqzlFjVkIg3SMtfYmuopTPf1EB4mP8 d08gJylcDZk= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id E6B7054BDA; Tue, 21 Apr 2020 19:06:24 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 7555F54BD9; Tue, 21 Apr 2020 19:06:24 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Taylor Blau Cc: git@vger.kernel.org, Elijah Newren , Jonathan Nieder , Derrick Stolee Subject: Re: [PATCH] shallow.c: use 'reset_repository_shallow' when appropriate References: <8d295389ea43c6b7e008514067b7af6eacba64a5.1587492422.git.me@ttaylorr.com> <20200421204516.GA69777@syl.local> <20200421222128.GA74697@syl.local> Date: Tue, 21 Apr 2020 16:06:23 -0700 In-Reply-To: <20200421222128.GA74697@syl.local> (Taylor Blau's message of "Tue, 21 Apr 2020 16:21:28 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: B8F4CA02-8424-11EA-B135-D1361DBA3BAF-77302942!pb-smtp2.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Taylor Blau writes: > Sorry, I think that the linked message is confusing (at least, it > confused me the second time I read it because I wasn't sure which part > of the mail Jonathan was asking about: my patch, or his response to my > patch). > > I think that he was referring to how I had it in the original patch I > sent in that thread, which was wrong. Based on my understanding of his > message, his recommendations match what I have in _this_ patch. Thanks for a clarification. > In either case, I'm sitting on another patch locally to improve the > style of the surrounding tests, which is done as a preparatory step > before this patch. I'll re-send after hearing back from you. Alright. Thanks.