From: Junio C Hamano <gitster@pobox.com>
To: Jacob Stopak <jacob@initialcommit.io>
Cc: git@vger.kernel.org
Subject: Re: Newbie contribution idea for 'git log --children': input requested
Date: Sun, 11 Sep 2022 17:41:21 -0700 [thread overview]
Message-ID: <xmqqillth1am.fsf@gitster.g> (raw)
In-Reply-To: <Yx5qjPhZ5AHkPHr7@MacBook-Pro-3.local> (Jacob Stopak's message of "Sun, 11 Sep 2022 16:09:00 -0700")
Jacob Stopak <jacob@initialcommit.io> writes:
> I'm not sure if this really qualifies as a "bug" per se, or if
> there is some way to do this that I'm just missing, or if it goes
> against the way Git's rev lists work.
As it goes against the way GIt's rev lists work, you can call that
"working in the way it was designed", or a "design bug".
> But I'm wondering if it could be addressed by simply adding a
> discrete check to see if any commits point to HEAD as a parent,
> (only when the --children option is used of course), and if so,
> populate those ids into the log message.
In a history where all commits and their parent-child relationship
can be enumerated and the links can be reversed in-core, it would be
trivial to implement. The challenge is to make sure it works
without wasting unusably large resources to do so in a real world
project. Having a commit-graph might help.
Thanks.
next prev parent reply other threads:[~2022-09-12 0:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 23:09 Newbie contribution idea for 'git log --children': input requested Jacob Stopak
2022-09-12 0:41 ` Junio C Hamano [this message]
2022-09-15 5:08 ` Jeff King
2022-09-15 17:08 ` Junio C Hamano
2022-09-18 3:19 ` Jacob Stopak
2022-09-20 22:28 ` Jeff King
2022-09-21 0:24 ` Jacob Stopak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqillth1am.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob@initialcommit.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).