From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] sha256: add support for Nettle
Date: Wed, 06 Jul 2022 16:05:01 -0700 [thread overview]
Message-ID: <xmqqilo94zc2.fsf@gitster.g> (raw)
In-Reply-To: <xmqqedyyi11y.fsf@gitster.g> (Junio C. Hamano's message of "Wed, 06 Jul 2022 10:49:29 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Perhaps "Let's add another option ..., which is Nettle, and give it
> preference over all others when multiple libraries are availalble"
> or something along that line?
>
>> diff --git a/sha256/nettle.h b/sha256/nettle.h
>> new file mode 100644
>> index 0000000000..9b2845babc
>> --- /dev/null
>> +++ b/sha256/nettle.h
>> @@ -0,0 +1,28 @@
>> +#ifndef SHA256_GCRYPT_H
>> +#define SHA256_GCRYPT_H
>
> Not really ;-)
FWIW, I needed the following to successfully build with
NETTLE_SHA256=YesPlease defined. The final linkage step complained
about missing nettle_SHA256_{Init,Update,Final}() functions without
the tweak.
diff --git c/sha256/nettle.h w/sha256/nettle.h
index 9b2845babc..8c93f29dda 100644
--- c/sha256/nettle.h
+++ w/sha256/nettle.h
@@ -1,21 +1,21 @@
-#ifndef SHA256_GCRYPT_H
-#define SHA256_GCRYPT_H
+#ifndef SHA256_NETTLE_H
+#define SHA256_NETTLE_H
#include <nettle/sha2.h>
typedef struct sha256_ctx nettle_SHA256_CTX;
-inline void nettle_SHA256_Init(nettle_SHA256_CTX *ctx)
+static inline void nettle_SHA256_Init(nettle_SHA256_CTX *ctx)
{
sha256_init(ctx);
}
-inline void nettle_SHA256_Update(nettle_SHA256_CTX *ctx, const void *data, size_t len)
+static inline void nettle_SHA256_Update(nettle_SHA256_CTX *ctx, const void *data, size_t len)
{
sha256_update(ctx, len, data);
}
-inline void nettle_SHA256_Final(unsigned char *digest, nettle_SHA256_CTX *ctx)
+static inline void nettle_SHA256_Final(unsigned char *digest, nettle_SHA256_CTX *ctx)
{
sha256_digest(ctx, SHA256_DIGEST_SIZE, digest);
}
next prev parent reply other threads:[~2022-07-06 23:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 23:05 [PATCH] sha256: add support for Nettle brian m. carlson
2022-07-06 1:00 ` Ramsay Jones
2022-07-06 1:08 ` brian m. carlson
2022-07-06 8:23 ` Jeff King
2022-07-06 8:45 ` Ævar Arnfjörð Bjarmason
2022-07-06 9:23 ` Jeff King
2022-07-06 10:39 ` brian m. carlson
2022-07-06 17:49 ` Junio C Hamano
2022-07-06 23:05 ` Junio C Hamano [this message]
2022-07-07 6:43 ` Junio C Hamano
2022-07-07 16:18 ` Junio C Hamano
2022-07-10 13:29 ` [PATCH v2] " brian m. carlson
2022-07-10 14:41 ` Ævar Arnfjörð Bjarmason
2022-07-10 16:39 ` Junio C Hamano
2022-07-10 20:12 ` brian m. carlson
2022-07-10 20:37 ` Junio C Hamano
2022-08-31 5:34 ` Reza Mahdi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqilo94zc2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).