git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Rafael Silva <rafaeloliveira.cs@gmail.com>,
	git@vger.kernel.org, Stefan Beller <stefanbeller@gmail.com>
Subject: Re: [PATCH 0/1] blame: remove unnecessary use of get_commit_info()
Date: Tue, 16 Feb 2021 11:45:27 -0800	[thread overview]
Message-ID: <xmqqim6rpzjc.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <ce29b876-a5dd-76e9-bf79-5b917249b508@gmail.com> (Derrick Stolee's message of "Tue, 16 Feb 2021 13:35:16 -0500")

Derrick Stolee <stolee@gmail.com> writes:

> ...
> This is a good way to demonstrate the change. Definitely worthwhile for
> demonstrating the value of the patch. I'll second Taylor's request that
> this performance data goes in the commit message so we can see the details
> in the future.

Thanks, all.  I do agree with you and Taylor that these numbers
deserve to be in the log message, not cover letter.

  reply	other threads:[~2021-02-16 19:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 16:31 [PATCH 0/1] blame: remove unnecessary use of get_commit_info() Rafael Silva
2021-02-16 16:31 ` [PATCH 1/1] " Rafael Silva
2021-02-16 17:10   ` Taylor Blau
2021-02-16 22:25     ` Rafael Silva
2021-02-16 18:35 ` [PATCH 0/1] " Derrick Stolee
2021-02-16 19:45   ` Junio C Hamano [this message]
2021-02-17 14:42   ` Rafael Silva
2021-02-17 14:54 ` [PATCH v2 " Rafael Silva
2021-02-17 14:54   ` [PATCH v2 1/1] " Rafael Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqim6rpzjc.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=rafaeloliveira.cs@gmail.com \
    --cc=stefanbeller@gmail.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).