From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Elijah Newren <newren@gmail.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Oct 2020, #03; Mon, 19)
Date: Fri, 23 Oct 2020 08:27:37 -0700 [thread overview]
Message-ID: <xmqqimb1hsie.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201023080202.GA4012156@coredump.intra.peff.net> (Jeff King's message of "Fri, 23 Oct 2020 04:02:02 -0400")
Jeff King <peff@peff.net> writes:
> On Mon, Oct 19, 2020 at 11:13:22AM -0700, Junio C Hamano wrote:
>
>> * en/strmap (2020-10-13) 10 commits
>> - strmap: enable allocations to come from a mem_pool
>> - strmap: add a strset sub-type
>> - strmap: add functions facilitating use as a string->int map
>> - strmap: enable faster clearing and reusing of strmaps
>> - strmap: add more utility functions
>> - strmap: new utility functions
>> - hashmap: introduce a new hashmap_partial_clear()
>> - hashmap: allow re-use after hashmap_free()
>> - hashmap: adjust spacing to fix argument alignment
>> - hashmap: add usage documentation explaining hashmap_free[_entries]()
>>
>> A speciailization of hashmap that uses a string as key has been
>> introduced. Hopefully it will see wider use over time.
>>
>> Will merge to 'next'.
>
> I haven't gotten a chance to look at this carefully yet, but note that
> the strset here sort-of conflicts with the one I added recently in
> builtin/shortlog.c (already in master). I think the compiler won't
> complain because they never show up in the same translation unit, but we
> should avoid having two almost-the-same types in the codebase.
>
> I suspect my "check_and_add" function could be folded into Elijah's
> implementation. The other big difference is that mine uses the
> FLEX_ALLOC approach, and his doesn't. I haven't digested the code and
> discussion around that from Elijah's series yet.
Will take a look at them again. Thanks.
next prev parent reply other threads:[~2020-10-23 15:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 18:13 What's cooking in git.git (Oct 2020, #03; Mon, 19) Junio C Hamano
2020-10-19 18:21 ` Eric Sunshine
2020-10-20 22:59 ` Junio C Hamano
2020-10-20 19:17 ` Preparing to rewind 'next' Junio C Hamano
2020-10-20 19:37 ` Matheus Tavares Bernardino
2020-10-21 14:48 ` mr/bisect-in-c-3, was Re: What's cooking in git.git (Oct 2020, #03; Mon, 19) Johannes Schindelin
2020-10-21 20:44 ` Junio C Hamano
2020-10-21 20:45 ` Junio C Hamano
2020-10-22 13:16 ` Johannes Schindelin
2020-10-23 8:02 ` Jeff King
2020-10-23 15:27 ` Junio C Hamano [this message]
2020-10-23 19:17 ` Elijah Newren
2020-10-27 8:39 ` Jeff King
2020-10-23 14:39 ` ak/corrected-commit-date, was " Jakub Narębski
2020-10-23 16:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqimb1hsie.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).