From: Junio C Hamano <email@example.com> To: "brian m. carlson" <firstname.lastname@example.org> Cc: Taylor Blau <email@example.com>, firstname.lastname@example.org, Matheus Tavares <email@example.com> Subject: Re: [PATCH] builtin/clone: avoid failure with GIT_DEFAULT_HASH Date: Mon, 14 Sep 2020 14:44:45 -0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> (Junio C. Hamano's message of "Mon, 14 Sep 2020 14:37:12 -0700") Junio C Hamano <firstname.lastname@example.org> writes: > "brian m. carlson" <email@example.com> writes: > >>> Alternatively, I certainly wouldn't complain if you did introduce a new >>> function and updated the call-site that passes reinit as 1. >> >> I thought about introducing a new function, but since it would share >> almost all of the code, it seemed a bit wasteful, even if the function >> is small. We do have only two callers, I believe, since I recall >> making this function non-static and calling it from clone, so I think >> it's okay. > > Perhaps. > > FWIW, this seems to have strange interaction with something in > 'seen' when merged; I suspect it is the topic that mucks with the > set-up sequence for "git clone", but didn't check. Actually I have to take it back. I have this directly on top of v2.28.0 and it already breaks tests big time. For example, here is how "cd t && sh t0021-conversion.sh -i -v" breaks: ... Cloning into 'repo-cloned'... fatal: could not unset 'extensions.objectformat' fatal: the remote end hung up unexpectedly not ok 25 - delayed checkout in process filter The story is the same if it is applied on top of 'master' (which is expected, as we haven't done anything to affect this area since v2.28.0).
next prev parent reply other threads:[~2020-09-14 21:44 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-11 15:17 Posible bug with GIT_DEFAULT_HASH during clone Matheus Tavares 2020-09-11 23:20 ` brian m. carlson 2020-09-11 23:38 ` [PATCH] builtin/clone: avoid failure with GIT_DEFAULT_HASH brian m. carlson 2020-09-12 3:24 ` Taylor Blau 2020-09-12 19:52 ` brian m. carlson 2020-09-14 21:37 ` Junio C Hamano 2020-09-14 21:44 ` Junio C Hamano [this message] 2020-09-15 1:32 ` brian m. carlson 2020-09-15 1:58 ` [PATCH v2] " brian m. carlson 2020-09-15 4:31 ` Junio C Hamano 2020-09-15 22:51 ` brian m. carlson 2020-09-20 22:35 ` [PATCH v3] " brian m. carlson 2020-09-21 4:27 ` Junio C Hamano 2020-09-22 9:17 ` brian m. carlson 2020-09-22 16:27 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] builtin/clone: avoid failure with GIT_DEFAULT_HASH' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).