From: Junio C Hamano <gitster@pobox.com>
To: "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
Philippe Blain <levraiphilippeblain@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Elijah Newren <newren@gmail.com>,
Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH 05/11] reset_head(): factor out ref updates
Date: Fri, 01 Oct 2021 14:00:26 -0700 [thread overview]
Message-ID: <xmqqlf3c5ul1.fsf@gitster.g> (raw)
In-Reply-To: <0744c3d143b5c2020267c5f9ad7da9303d7a7835.1633082702.git.gitgitgadget@gmail.com> (Phillip Wood via GitGitGadget's message of "Fri, 01 Oct 2021 10:04:56 +0000")
"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> In the next commit we will stop trying to update HEAD when we are just
> clearing changes from the working tree. Move the code that updates the
"clearing changes" meaning...? Like "rebase --abort"?
> refs to its own function in preparation for that.
>
> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
> ---
> reset.c | 112 +++++++++++++++++++++++++++++++-------------------------
> 1 file changed, 62 insertions(+), 50 deletions(-)
>
> diff --git a/reset.c b/reset.c
> index 9ab007c0c34..668c7639127 100644
> --- a/reset.c
> +++ b/reset.c
> @@ -8,26 +8,75 @@
> #include "tree.h"
> #include "unpack-trees.h"
>
> +static int update_refs(const struct object_id *oid, const char *switch_to_branch,
> + const char *reflog_head, const char *reflog_orig_head,
> + const char *default_reflog_action, unsigned flags)
> +{
> + unsigned detach_head = flags & RESET_HEAD_DETACH;
> + unsigned run_hook = flags & RESET_HEAD_RUN_POST_CHECKOUT_HOOK;
> + unsigned update_orig_head = flags & RESET_ORIG_HEAD;
> + struct object_id *orig = NULL, oid_orig, *old_orig = NULL, oid_old_orig;
> + struct strbuf msg = STRBUF_INIT;
> + const char *reflog_action;
> + size_t prefix_len;
> + int ret;
> +
> + reflog_action = getenv(GIT_REFLOG_ACTION_ENVIRONMENT);
> + strbuf_addf(&msg, "%s: ", reflog_action ? reflog_action : default_reflog_action);
> + prefix_len = msg.len;
> +
> + if (update_orig_head) {
> + if (!get_oid("ORIG_HEAD", &oid_old_orig))
> + old_orig = &oid_old_orig;
> + if (!get_oid("HEAD", &oid_orig)) {
> + orig = &oid_orig;
> + if (!reflog_orig_head) {
> + strbuf_addstr(&msg, "updating ORIG_HEAD");
> + reflog_orig_head = msg.buf;
> + }
> + update_ref(reflog_orig_head, "ORIG_HEAD", orig,
> + old_orig, 0, UPDATE_REFS_MSG_ON_ERR);
> + } else if (old_orig)
> + delete_ref(NULL, "ORIG_HEAD", old_orig, 0);
> + }
> +
> + if (!reflog_head) {
> + strbuf_setlen(&msg, prefix_len);
> + strbuf_addstr(&msg, "updating HEAD");
> + reflog_head = msg.buf;
> + }
> + if (!switch_to_branch)
> + ret = update_ref(reflog_head, "HEAD", oid, orig,
> + detach_head ? REF_NO_DEREF : 0,
> + UPDATE_REFS_MSG_ON_ERR);
> + else {
> + ret = update_ref(reflog_head, switch_to_branch, oid,
> + NULL, 0, UPDATE_REFS_MSG_ON_ERR);
> + if (!ret)
> + ret = create_symref("HEAD", switch_to_branch,
> + reflog_head);
> + }
> + if (!ret && run_hook)
> + run_hook_le(NULL, "post-checkout",
> + oid_to_hex(orig ? orig : null_oid()),
> + oid_to_hex(oid), "1", NULL);
> + strbuf_release(&msg);
> + return ret;
> +}
> +
> int reset_head(struct repository *r, struct object_id *oid,
> const char *switch_to_branch, unsigned flags,
> const char *reflog_orig_head, const char *reflog_head,
> const char *default_reflog_action)
> {
> - unsigned detach_head = flags & RESET_HEAD_DETACH;
> unsigned reset_hard = flags & RESET_HEAD_HARD;
> - unsigned run_hook = flags & RESET_HEAD_RUN_POST_CHECKOUT_HOOK;
> unsigned refs_only = flags & RESET_HEAD_REFS_ONLY;
> - unsigned update_orig_head = flags & RESET_ORIG_HEAD;
> struct object_id head_oid;
> struct tree_desc desc[2] = { { NULL }, { NULL } };
> struct lock_file lock = LOCK_INIT;
> struct unpack_trees_options unpack_tree_opts = { 0 };
> struct tree *tree;
> - const char *action, *reflog_action;
> - struct strbuf msg = STRBUF_INIT;
> - size_t prefix_len;
> - struct object_id *orig = NULL, oid_orig,
> - *old_orig = NULL, oid_old_orig;
> + const char *action;
> int ret = 0, nr = 0;
>
> if (switch_to_branch && !starts_with(switch_to_branch, "refs/"))
> @@ -47,7 +96,9 @@ int reset_head(struct repository *r, struct object_id *oid,
> oid = &head_oid;
>
> if (refs_only)
> - goto reset_head_refs;
> + return update_refs(oid, switch_to_branch, reflog_head,
> + reflog_orig_head, default_reflog_action,
> + flags);
>
> action = reset_hard ? "reset" : "checkout";
> setup_unpack_trees_porcelain(&unpack_tree_opts, action);
> @@ -90,49 +141,10 @@ int reset_head(struct repository *r, struct object_id *oid,
> goto leave_reset_head;
> }
>
> -reset_head_refs:
> - reflog_action = getenv(GIT_REFLOG_ACTION_ENVIRONMENT);
> - strbuf_addf(&msg, "%s: ", reflog_action ? reflog_action : default_reflog_action);
> - prefix_len = msg.len;
> -
> - if (update_orig_head) {
> - if (!get_oid("ORIG_HEAD", &oid_old_orig))
> - old_orig = &oid_old_orig;
> - if (!get_oid("HEAD", &oid_orig)) {
> - orig = &oid_orig;
> - if (!reflog_orig_head) {
> - strbuf_addstr(&msg, "updating ORIG_HEAD");
> - reflog_orig_head = msg.buf;
> - }
> - update_ref(reflog_orig_head, "ORIG_HEAD", orig,
> - old_orig, 0, UPDATE_REFS_MSG_ON_ERR);
> - } else if (old_orig)
> - delete_ref(NULL, "ORIG_HEAD", old_orig, 0);
> - }
> -
> - if (!reflog_head) {
> - strbuf_setlen(&msg, prefix_len);
> - strbuf_addstr(&msg, "updating HEAD");
> - reflog_head = msg.buf;
> - }
> - if (!switch_to_branch)
> - ret = update_ref(reflog_head, "HEAD", oid, orig,
> - detach_head ? REF_NO_DEREF : 0,
> - UPDATE_REFS_MSG_ON_ERR);
> - else {
> - ret = update_ref(reflog_head, switch_to_branch, oid,
> - NULL, 0, UPDATE_REFS_MSG_ON_ERR);
> - if (!ret)
> - ret = create_symref("HEAD", switch_to_branch,
> - reflog_head);
> - }
> - if (!ret && run_hook)
> - run_hook_le(NULL, "post-checkout",
> - oid_to_hex(orig ? orig : null_oid()),
> - oid_to_hex(oid), "1", NULL);
> + ret = update_refs(oid, switch_to_branch, reflog_head, reflog_orig_head,
> + default_reflog_action, flags);
>
> leave_reset_head:
> - strbuf_release(&msg);
> rollback_lock_file(&lock);
> clear_unpack_trees_porcelain(&unpack_tree_opts);
> while (nr)
next prev parent reply other threads:[~2021-10-01 21:00 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 10:04 [PATCH 00/11] rebase: reset_head() related fixes and improvements Phillip Wood via GitGitGadget
2021-10-01 10:04 ` [PATCH 01/11] rebase: factor out checkout for up to date branch Phillip Wood via GitGitGadget
2021-10-01 10:04 ` [PATCH 02/11] reset_head(): fix checkout Phillip Wood via GitGitGadget
2021-10-01 20:26 ` Junio C Hamano
2021-10-04 9:58 ` Phillip Wood
2021-10-04 16:13 ` Junio C Hamano
2021-10-01 22:47 ` Eric Sunshine
2021-10-01 10:04 ` [PATCH 03/11] reset_head(): don't run checkout hook if there is an error Phillip Wood via GitGitGadget
2021-10-01 20:52 ` Junio C Hamano
2021-10-04 10:00 ` Phillip Wood
2021-10-12 8:48 ` Ævar Arnfjörð Bjarmason
2021-10-01 10:04 ` [PATCH 04/11] reset_head(): remove action parameter Phillip Wood via GitGitGadget
2021-10-01 20:58 ` Junio C Hamano
2021-10-04 10:00 ` Phillip Wood
2021-10-01 10:04 ` [PATCH 05/11] reset_head(): factor out ref updates Phillip Wood via GitGitGadget
2021-10-01 21:00 ` Junio C Hamano [this message]
2021-10-04 10:03 ` Phillip Wood
2021-10-01 10:04 ` [PATCH 06/11] reset_head(): make default_reflog_action optional Phillip Wood via GitGitGadget
2021-10-01 21:03 ` Junio C Hamano
2021-10-01 21:08 ` Junio C Hamano
2021-10-04 10:03 ` Phillip Wood
2021-10-01 10:04 ` [PATCH 07/11] rebase: cleanup reset_head() calls Phillip Wood via GitGitGadget
2021-10-01 10:04 ` [PATCH 08/11] reset_head(): take struct rebase_head_opts Phillip Wood via GitGitGadget
2021-10-01 21:11 ` Junio C Hamano
2021-10-04 10:09 ` Phillip Wood
2021-10-01 10:05 ` [PATCH 09/11] rebase --apply: fix reflog Phillip Wood via GitGitGadget
2021-10-01 21:12 ` Junio C Hamano
2021-10-01 10:05 ` [PATCH 10/11] rebase --apply: set ORIG_HEAD correctly Phillip Wood via GitGitGadget
2021-10-01 21:18 ` Junio C Hamano
2021-10-01 10:05 ` [PATCH 11/11] rebase -m: don't fork git checkout Phillip Wood via GitGitGadget
2021-10-02 0:38 ` [PATCH 00/11] rebase: reset_head() related fixes and improvements Junio C Hamano
2021-10-02 4:58 ` Junio C Hamano
2021-10-02 12:27 ` Phillip Wood
2021-10-02 13:12 ` Phillip Wood
2021-10-02 13:38 ` René Scharfe
2021-10-06 14:03 ` Phillip Wood
2021-12-08 14:57 ` [PATCH v2 00/14] " Phillip Wood via GitGitGadget
2021-12-08 14:57 ` [PATCH v2 01/14] rebase: factor out checkout for up to date branch Phillip Wood via GitGitGadget
2021-12-09 21:04 ` Junio C Hamano
2021-12-08 14:57 ` [PATCH v2 02/14] t5403: refactor rebase post-checkout hook tests Phillip Wood via GitGitGadget
2021-12-09 18:24 ` Junio C Hamano
2021-12-08 14:57 ` [PATCH v2 03/14] rebase: pass correct arguments to post-checkout hook Phillip Wood via GitGitGadget
2021-12-09 18:53 ` Junio C Hamano
2021-12-08 14:57 ` [PATCH v2 04/14] rebase: do not remove untracked files on checkout Phillip Wood via GitGitGadget
2021-12-09 19:09 ` Junio C Hamano
2021-12-08 14:57 ` [PATCH v2 05/14] rebase --apply: don't run post-checkout hook if there is an error Phillip Wood via GitGitGadget
2021-12-08 14:57 ` [PATCH v2 06/14] reset_head(): remove action parameter Phillip Wood via GitGitGadget
2021-12-08 14:57 ` [PATCH v2 07/14] create_autostash(): remove unneeded parameter Phillip Wood via GitGitGadget
2021-12-09 19:17 ` Junio C Hamano
2022-01-25 11:06 ` Phillip Wood
2021-12-08 14:57 ` [PATCH v2 08/14] reset_head(): factor out ref updates Phillip Wood via GitGitGadget
2021-12-08 14:57 ` [PATCH v2 09/14] reset_head(): make default_reflog_action optional Phillip Wood via GitGitGadget
2021-12-09 19:23 ` Junio C Hamano
2021-12-08 14:57 ` [PATCH v2 10/14] rebase: cleanup reset_head() calls Phillip Wood via GitGitGadget
2021-12-09 19:26 ` Junio C Hamano
2022-01-25 11:07 ` Phillip Wood
2021-12-08 14:57 ` [PATCH v2 11/14] reset_head(): take struct rebase_head_opts Phillip Wood via GitGitGadget
2021-12-09 19:31 ` Junio C Hamano
2021-12-08 14:57 ` [PATCH v2 12/14] rebase --apply: fix reflog Phillip Wood via GitGitGadget
2021-12-09 20:49 ` Junio C Hamano
2021-12-08 14:58 ` [PATCH v2 13/14] rebase --apply: set ORIG_HEAD correctly Phillip Wood via GitGitGadget
2021-12-11 10:59 ` Elijah Newren
2021-12-08 14:58 ` [PATCH v2 14/14] rebase -m: don't fork git checkout Phillip Wood via GitGitGadget
2021-12-09 21:04 ` [PATCH v2 00/14] rebase: reset_head() related fixes and improvements Junio C Hamano
2022-01-26 10:53 ` Phillip Wood
2022-01-27 17:37 ` Junio C Hamano
2021-12-11 11:05 ` Elijah Newren
2022-01-26 13:05 ` [PATCH v3 " Phillip Wood via GitGitGadget
2022-01-26 13:05 ` [PATCH v3 01/14] rebase: factor out checkout for up to date branch Phillip Wood via GitGitGadget
2022-01-26 13:05 ` [PATCH v3 02/14] t5403: refactor rebase post-checkout hook tests Phillip Wood via GitGitGadget
2022-01-26 13:05 ` [PATCH v3 03/14] rebase: pass correct arguments to post-checkout hook Phillip Wood via GitGitGadget
2022-01-26 13:05 ` [PATCH v3 04/14] rebase: do not remove untracked files on checkout Phillip Wood via GitGitGadget
2022-01-26 13:05 ` [PATCH v3 05/14] rebase --apply: don't run post-checkout hook if there is an error Phillip Wood via GitGitGadget
2022-01-26 13:05 ` [PATCH v3 06/14] reset_head(): remove action parameter Phillip Wood via GitGitGadget
2022-01-26 13:05 ` [PATCH v3 07/14] reset_head(): factor out ref updates Phillip Wood via GitGitGadget
2022-01-26 13:05 ` [PATCH v3 08/14] reset_head(): make default_reflog_action optional Phillip Wood via GitGitGadget
2022-01-26 13:05 ` [PATCH v3 09/14] create_autostash(): remove unneeded parameter Phillip Wood via GitGitGadget
2022-01-26 13:05 ` [PATCH v3 10/14] rebase: cleanup reset_head() calls Phillip Wood via GitGitGadget
2022-01-26 13:05 ` [PATCH v3 11/14] reset_head(): take struct rebase_head_opts Phillip Wood via GitGitGadget
2022-01-26 13:35 ` Ævar Arnfjörð Bjarmason
2022-01-26 14:52 ` Phillip Wood
2022-01-26 13:05 ` [PATCH v3 12/14] rebase --apply: fix reflog Phillip Wood via GitGitGadget
2022-01-26 13:05 ` [PATCH v3 13/14] rebase --apply: set ORIG_HEAD correctly Phillip Wood via GitGitGadget
2022-01-26 13:05 ` [PATCH v3 14/14] rebase -m: don't fork git checkout Phillip Wood via GitGitGadget
2022-02-01 17:03 ` [PATCH v3 00/14] rebase: reset_head() related fixes and improvements Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlf3c5ul1.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=levraiphilippeblain@gmail.com \
--cc=newren@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).