From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Mike Rappazzo <rappazzo@gmail.com>,
Michael Rappazzo via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH 0/1] sequencer: comment out the 'squash!' line
Date: Tue, 07 Jan 2020 08:15:16 -0800 [thread overview]
Message-ID: <xmqqlfqj6y5n.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20200107013401.GI6570@camp.crustytoothpaste.net> (brian m. carlson's message of "Tue, 7 Jan 2020 01:34:01 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> I can see the argument that this makes it a little harder for mechanical
> processing across versions, but I suspect most of that looks something
> like "sed -i -e '/^squash! /d' COMMIT_EDITMSG" and it probably won't be
> affected.
With the left-anchoring, the search pattern will no longer find that
line if "squash!" is commented out, but people tend to be sloppy and
do not anchor the pattern would not notice the difference. Perhaps
the downside may not be too severe? I dunno.
> We do make occasional slightly incompatible changes across
> versions in order to improve user experience, and I think a lot of folks
> who use squash commits will find this a pleasant improvement.
next prev parent reply other threads:[~2020-01-07 16:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 16:04 [PATCH 0/1] sequencer: comment out the 'squash!' line Michael Rappazzo via GitGitGadget
2020-01-06 16:04 ` [PATCH 1/1] " Michael Rappazzo via GitGitGadget
2020-01-06 17:10 ` Phillip Wood
2020-01-06 17:34 ` Mike Rappazzo
2020-01-06 17:32 ` [PATCH 0/1] " Junio C Hamano
2020-01-06 19:20 ` Mike Rappazzo
2020-01-06 19:32 ` Jeff King
2020-01-07 3:36 ` Jonathan Nieder
2020-01-07 11:15 ` Jeff King
2020-01-06 20:41 ` Junio C Hamano
2020-01-07 1:34 ` brian m. carlson
2020-01-07 16:15 ` Junio C Hamano [this message]
2020-01-08 2:55 ` brian m. carlson
2020-01-08 13:23 ` Johannes Schindelin
2020-01-08 16:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlfqj6y5n.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=rappazzo@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).