From: Junio C Hamano <gitster@pobox.com>
To: "elonderin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, thomas menzel <github@tomsit.de>
Subject: Re: [PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs
Date: Mon, 06 Jan 2020 09:13:53 -0800 [thread overview]
Message-ID: <xmqqlfqka4oe.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <b032358ca97df3bd5605ff356196f82a1f16a320.1578322213.git.gitgitgadget@gmail.com> (elonderin via GitGitGadget's message of "Mon, 06 Jan 2020 14:50:13 +0000")
"elonderin via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: elonderin <8225602+elonderin@users.noreply.github.com>
>
> The sentence wants to talk about the superproject's possesive, not plural form.
>
> Signed-off-by: thomas menzel dev@tomsit.de
The author of the patch must sign-off, so the above three lines
should look more like so:
From: Thomas Menzel <dev@tomsit.de>
The sentence wants to talk about the superproject's
possesive, not plural form.
From: Thomas Menzel <dev@tomsit.de>
The content of the patch obviously is correct.
Thanks.
> ---
> Documentation/git-submodule.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
> index 22425cbc76..5232407f68 100644
> --- a/Documentation/git-submodule.txt
> +++ b/Documentation/git-submodule.txt
> @@ -248,7 +248,7 @@ registered submodules, and sync any nested submodules within.
>
> absorbgitdirs::
> If a git directory of a submodule is inside the submodule,
> - move the git directory of the submodule into its superprojects
> + move the git directory of the submodule into its superproject's
> `$GIT_DIR/modules` path and then connect the git directory and
> its working directory by setting the `core.worktree` and adding
> a .git file pointing to the git directory embedded in the
next prev parent reply other threads:[~2020-01-06 17:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 14:50 [PATCH 0/1] doc: fixed a typo in git-submodule.txt thomas menzel via GitGitGadget
2020-01-06 14:50 ` [PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs elonderin via GitGitGadget
2020-01-06 17:13 ` Junio C Hamano [this message]
2020-01-06 17:18 ` Junio C Hamano
2020-01-06 22:52 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlfqka4oe.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=github@tomsit.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).