From: Junio C Hamano <gitster@pobox.com>
To: Shulhan <m.shulhan@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] builtin/remote: quote remote name on error to display empty name
Date: Thu, 13 Sep 2018 15:01:50 -0700 [thread overview]
Message-ID: <xmqqlg85dpkh.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <xmqqpnxhdq0z.fsf@gitster-ct.c.googlers.com> (Junio C. Hamano's message of "Thu, 13 Sep 2018 14:51:56 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Have you run "make test" with this change?
>
> I expect at least 5505.10 to fail without adjustment.
For now, I'll queue this on top, and if this turns out to be
sufficient, I will squash it in.
t/t5505-remote.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
index 241e6a319d..d2a2cdd453 100755
--- a/t/t5505-remote.sh
+++ b/t/t5505-remote.sh
@@ -145,7 +145,7 @@ test_expect_success 'remove remote protects local branches' '
test_expect_success 'remove errors out early when deleting non-existent branch' '
(
cd test &&
- echo "fatal: No such remote: foo" >expect &&
+ echo "fatal: No such remote: '\''foo'\''" >expect &&
test_must_fail git remote rm foo 2>actual &&
test_i18ncmp expect actual
)
@@ -173,7 +173,7 @@ test_expect_success 'remove remote with a branch without configured merge' '
test_expect_success 'rename errors out early when deleting non-existent branch' '
(
cd test &&
- echo "fatal: No such remote: foo" >expect &&
+ echo "fatal: No such remote: '\''foo'\''" >expect &&
test_must_fail git remote rename foo bar 2>actual &&
test_i18ncmp expect actual
)
next prev parent reply other threads:[~2018-09-13 22:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 13:18 [PATCH v2] builtin/remote: quote remote name on error to display empty name Shulhan
2018-09-13 21:51 ` Junio C Hamano
2018-09-13 22:01 ` Junio C Hamano [this message]
2018-09-14 8:17 ` Shulhan
2018-09-14 16:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlg85dpkh.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=m.shulhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).