git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] submodule: use the imperative mood to describe the --files option
@ 2021-05-16 21:59 Alex Henrie
  2021-05-17  5:58 ` Bagas Sanjaya
  2021-05-17  6:56 ` Junio C Hamano
  0 siblings, 2 replies; 3+ messages in thread
From: Alex Henrie @ 2021-05-16 21:59 UTC (permalink / raw)
  To: git, pc44800, chriscool, stefanbeller, kaartic.sivaraam,
	Johannes.Schindelin, shouryashukla.oo, gitster
  Cc: Alex Henrie

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
 builtin/submodule--helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index d55f6262e9..ae6174ab05 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -1300,7 +1300,7 @@ static int module_summary(int argc, const char **argv, const char *prefix)
 		OPT_BOOL(0, "cached", &cached,
 			 N_("use the commit stored in the index instead of the submodule HEAD")),
 		OPT_BOOL(0, "files", &files,
-			 N_("to compare the commit in the index with that in the submodule HEAD")),
+			 N_("compare the commit in the index with that in the submodule HEAD")),
 		OPT_BOOL(0, "for-status", &for_status,
 			 N_("skip submodules with 'ignore_config' value set to 'all'")),
 		OPT_INTEGER('n', "summary-limit", &summary_limit,
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] submodule: use the imperative mood to describe the --files option
  2021-05-16 21:59 [PATCH] submodule: use the imperative mood to describe the --files option Alex Henrie
@ 2021-05-17  5:58 ` Bagas Sanjaya
  2021-05-17  6:56 ` Junio C Hamano
  1 sibling, 0 replies; 3+ messages in thread
From: Bagas Sanjaya @ 2021-05-17  5:58 UTC (permalink / raw)
  To: Alex Henrie, git, pc44800, chriscool, stefanbeller,
	kaartic.sivaraam, Johannes.Schindelin, shouryashukla.oo, gitster

Hi Alex,

On 17/05/21 04.59, Alex Henrie wrote:
> -			 N_("to compare the commit in the index with that in the submodule HEAD")),
> +			 N_("compare the commit in the index with that in the submodule HEAD")),

Seems correct.

FYI, on my native language (Indonesian), we say "Review yourself" as
"Tinjau dirimu" for imperative mood. Unfortunately many imperative
sentences on software l10n instead prefix the verb with "me-", such as
"meninjau dirimu". That is not imperative mood; that is descriptive
mood with infinitive verb form.

Anyway, thanks.

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] submodule: use the imperative mood to describe the --files option
  2021-05-16 21:59 [PATCH] submodule: use the imperative mood to describe the --files option Alex Henrie
  2021-05-17  5:58 ` Bagas Sanjaya
@ 2021-05-17  6:56 ` Junio C Hamano
  1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2021-05-17  6:56 UTC (permalink / raw)
  To: Alex Henrie
  Cc: git, pc44800, chriscool, stefanbeller, kaartic.sivaraam,
	Johannes.Schindelin, shouryashukla.oo

Alex Henrie <alexhenrie24@gmail.com> writes:

> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
>  builtin/submodule--helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index d55f6262e9..ae6174ab05 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -1300,7 +1300,7 @@ static int module_summary(int argc, const char **argv, const char *prefix)
>  		OPT_BOOL(0, "cached", &cached,
>  			 N_("use the commit stored in the index instead of the submodule HEAD")),
>  		OPT_BOOL(0, "files", &files,
> -			 N_("to compare the commit in the index with that in the submodule HEAD")),
> +			 N_("compare the commit in the index with that in the submodule HEAD")),
>  		OPT_BOOL(0, "for-status", &for_status,
>  			 N_("skip submodules with 'ignore_config' value set to 'all'")),
>  		OPT_INTEGER('n', "summary-limit", &summary_limit,

Unlike many other helper functions in this file, this one is likely
to survive when the remainder of "git submodule" scripted Porcelain
is rewritten in C, so it is a good idea to update it with this
patch.

Thanks, will queue.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-17  6:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-16 21:59 [PATCH] submodule: use the imperative mood to describe the --files option Alex Henrie
2021-05-17  5:58 ` Bagas Sanjaya
2021-05-17  6:56 ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).