git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Miriam Rubio <mirucam@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v8 0/6] Finish converting git bisect to C part 2 subset 1
Date: Wed, 23 Sep 2020 09:14:57 -0700	[thread overview]
Message-ID: <xmqqmu1gjwqm.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200923072740.20772-1-mirucam@gmail.com> (Miriam Rubio's message of "Wed, 23 Sep 2020 09:27:34 +0200")

Miriam Rubio <mirucam@gmail.com> writes:

> These patches correspond to a second part of patch series 
> of Outreachy project "Finish converting `git bisect` from shell to C" 
> started by Pranit Bauva and Tanushree Tumane
> (https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and
> continued by me.
>
> This patch series version is composed by the first six patches of the
> previous version due to a bug discovered during the test stage, that 
> affects the rest of the patches and that needs to be fixed before 
> sending them.

Thanks for being careful.

> * Rebased on 385c171a01, (Fifteenth batch, 2020-09-18) to update command
> help messages.

Personally I find this rebase unwarranted.  What ef4d9f8a (bisect:
swap command-line options in documentation, 2020-08-28) on the
'master' did does not overlap with this series in any meaningful
way.  Since it is also trivial to adjust these patches back on
e9b77c84 (Tenth batch, 2020-08-24) on which the previous round was
based, I won't complain ;-)

> [4/6] bisect--helper: reimplement `bisect_autostart` shell function in C
>
> * Amend commit message.
> * Change to `return -1` when we cannot autostart.
> * Add `|| exit` to bisect-autostart call in shell script.

Sounds good.

> [6/6] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell
>  functions in C
>  
> * Amend commit message.
> * Amend new modes order in cmdmode enum.

Meaning that the two new ones can just be at the end and there
wasn't a reason for them to come before autostart?  OK.

> * Add `|| exit` to bisect-auto-next call in shell script.

OK.

Thanks.

      parent reply	other threads:[~2020-09-23 16:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23  7:27 [PATCH v8 0/6] Finish converting git bisect to C part 2 subset 1 Miriam Rubio
2020-09-23  7:27 ` [PATCH v8 1/6] bisect--helper: BUG() in cmd_*() on invalid subcommand Miriam Rubio
2020-09-23  7:27 ` [PATCH v8 2/6] bisect--helper: use '-res' in 'cmd_bisect__helper' return Miriam Rubio
2020-09-23  7:27 ` [PATCH v8 3/6] bisect--helper: introduce new `write_in_file()` function Miriam Rubio
2020-09-23  7:27 ` [PATCH v8 4/6] bisect--helper: reimplement `bisect_autostart` shell function in C Miriam Rubio
2020-09-23 14:41   ` Johannes Schindelin
2020-09-23  7:27 ` [PATCH v8 5/6] bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()' Miriam Rubio
2020-09-23  7:27 ` [PATCH v8 6/6] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell functions in C Miriam Rubio
2020-09-23 14:46 ` [PATCH v8 0/6] Finish converting git bisect to C part 2 subset 1 Johannes Schindelin
2020-09-23 16:14 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmu1gjwqm.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mirucam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).