From: Junio C Hamano <gitster@pobox.com>
To: Darren Tucker <dtucker@dtucker.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 6/7] Check if strtoumax is a macro (eg HP-UX 11.11).
Date: Mon, 18 May 2020 10:17:00 -0700 [thread overview]
Message-ID: <xmqqo8ql40z7.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200518100356.29292-6-dtucker@dtucker.net> (Darren Tucker's message of "Mon, 18 May 2020 20:03:55 +1000")
Darren Tucker <dtucker@dtucker.net> writes:
> Signed-off-by: Darren Tucker <dtucker@dtucker.net>
> ---
> configure.ac | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 14e09b04b6..87a39c5ae0 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1164,10 +1164,16 @@ GIT_CHECK_FUNC(strtoull,
> [NO_STRTOULL=YesPlease])
> GIT_CONF_SUBST([NO_STRTOULL])
> #
> -# Define NO_STRTOUMAX if you don't have strtoumax in the C library.
> +# Define NO_STRTOUMAX if you don't have strtoumax in the C library
> +# or as a macro in inttypes.h.
> GIT_CHECK_FUNC(strtoumax,
> [NO_STRTOUMAX=],
> -[NO_STRTOUMAX=YesPlease])
> +[
> + AC_CHECK_DECL(strtoumax,
> + [NO_STRTOUMAX=],
> + [NO_STRTOUMAX=YesPlease],
> + [#include <inttypes.h>])
> +])
It is kind of surprising that we got away with GIT_CHECK_FUNC() that
misses an implementation by macro without having problems with other
symbols.
I don't mind taking this patch as-is, but it makes me wonder if we
need to devise a more systematic approach to the issue than "oh, I
found GIT_CHECK_FUNC() does not work for X on system Y, so let's add
an AC_CHECK_DECL() for it, too" approach, which this patch is its
first step.
Thanks.
next prev parent reply other threads:[~2020-05-18 17:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 10:03 [PATCH 1/7] Redirect grep's stderr top null too Darren Tucker
2020-05-18 10:03 ` [PATCH 2/7] Define NO_PREAD for HPUX 11.11 and 11.00 Darren Tucker
2020-05-18 10:03 ` [PATCH 3/7] Test for strtoull in configure Darren Tucker
2020-05-18 10:03 ` [PATCH 4/7] Use strtoumax instead of strtoull Darren Tucker
2020-05-18 18:29 ` Junio C Hamano
2020-05-18 10:03 ` [PATCH 5/7] Define LLONG_MAX/MIN etc if not already defined Darren Tucker
2020-05-18 10:24 ` Andreas Schwab
2020-05-18 14:41 ` Darren Tucker
2020-05-18 10:03 ` [PATCH 6/7] Check if strtoumax is a macro (eg HP-UX 11.11) Darren Tucker
2020-05-18 17:17 ` Junio C Hamano [this message]
2020-05-20 1:49 ` Darren Tucker
2020-05-20 3:19 ` Junio C Hamano
2020-05-18 10:03 ` [PATCH 7/7] Define SCNuMAX if not already defined Darren Tucker
2020-05-18 14:13 ` [PATCH 1/7] Redirect grep's stderr top null too Đoàn Trần Công Danh
2020-05-18 14:29 ` Darren Tucker
2020-05-18 15:30 ` Đoàn Trần Công Danh
2020-05-18 23:22 ` Darren Tucker
2020-05-19 0:56 ` [PATCH] t5703: replace "grep -a" usage by perl Đoàn Trần Công Danh
2020-05-19 2:22 ` Darren Tucker
2020-05-19 7:13 ` Christian Couder
2020-05-19 11:39 ` Đoàn Trần Công Danh
2020-05-19 14:13 ` Christian Couder
2020-05-19 16:09 ` [PATCH 1/7] Redirect grep's stderr top null too Eric Sunshine
2020-05-18 18:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo8ql40z7.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=dtucker@dtucker.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).