git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
	"Jeff King" <peff@peff.net>,
	"GIT Mailing-list" <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep
Date: Wed, 28 Feb 2018 08:18:37 -0800	[thread overview]
Message-ID: <xmqqo9k9m6jm.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <ffc3d3dc-6d21-4273-5362-cbf32e7e4e59@ramsayjones.plus.com> (Ramsay Jones's message of "Wed, 28 Feb 2018 15:33:51 +0000")

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

>> However, I'm not sure about the authorship and taking credit for the
>> patch.  We ended up taking my patch, sure, but I think Ramsay did all
>> the real hard work, i.e. writing the commit message and, most
>> importantly, realizing that something is wrong with that '...| sort' at
>> the end of the line.
>
> No, the patch and the credit are yours, I was just trying to
> help out and get the patches moving forward. At most, I would
> think a 'Helped-by:' would be sufficient to note my input.

OK.


> [BTW, my 'Signed-off-by:' on that patch was in the spirit of
> the dco section b. - again I wasn't quite sure ...]

I take your "wasn't" to imply that by now you are a bit more sure?
It was a perfectly fine "I am passing it along" sign-off.

Thanks, both.

      reply	other threads:[~2018-02-28 16:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12  0:18 [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep Ramsay Jones
2018-02-12 20:18 ` Junio C Hamano
2018-02-12 21:12   ` Junio C Hamano
2018-02-13  1:58   ` Ramsay Jones
2018-02-13  7:51     ` Junio C Hamano
2018-02-13 10:04       ` SZEDER Gábor
2018-02-13 17:08         ` Junio C Hamano
2018-02-13 17:26           ` Jeff King
2018-02-13 18:10             ` Junio C Hamano
2018-02-27 20:16               ` Junio C Hamano
2018-02-27 22:05                 ` Junio C Hamano
2018-02-27 23:47                   ` Ramsay Jones
2018-02-28  0:42                     ` SZEDER Gábor
2018-02-28 15:33                       ` Ramsay Jones
2018-02-28 16:18                         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo9k9m6jm.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ramsay@ramsayjones.plus.com \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).