git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Turner <dturner@twopensource.com>
Cc: Michael Haggerty <mhagger@alum.mit.edu>,
	git@vger.kernel.org,
	Christian Couder <christian.couder@gmail.com>
Subject: Re: [PATCH v5 2/3] path: optimize common dir checking
Date: Mon, 05 Oct 2015 13:43:21 -0700	[thread overview]
Message-ID: <xmqqoagdxd06.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqsi5pxdc0.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Mon, 05 Oct 2015 13:36:15 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> David Turner <dturner@twopensource.com> writes:
>
>> But this is a benchmark of just git_path.  I don't happen to see any
>> cases where git_path is taking up an appreciable amount of runtime.
>>
>> I only added this because Junio requested a speedup.  So I am perfectly
>> happy to drop this patch from the series.  
>
> Ok, then let's drop it for now.  Thanks.

Having said all that, this conversation happened way after I started
today's integration cycle, I am not inclined to redo all of that,
especially with extra tagging involved in the work done today.

So it is in 'master' now.  I'm open to a patch to revert this
commit, though.

Thanks.

  reply	other threads:[~2015-10-05 20:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01  2:13 (unknown), David Turner
2015-09-01  2:13 ` [PATCH v5 1/3] refs: clean up common_list David Turner
2015-09-01  2:13 ` [PATCH v5 2/3] path: optimize common dir checking David Turner
2015-10-05  3:00   ` Michael Haggerty
2015-10-05 17:22     ` Junio C Hamano
2015-10-05 20:10       ` David Turner
2015-10-05 20:36         ` Junio C Hamano
2015-10-05 20:43           ` Junio C Hamano [this message]
2015-09-01  2:13 ` [PATCH v5 3/3] refs: make refs/bisect/* per-worktree David Turner
2015-09-01 16:32 ` making refs/bisect/ per worktree (was Re: (unknown)) Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqoagdxd06.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=dturner@twopensource.com \
    --cc=git@vger.kernel.org \
    --cc=mhagger@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).