git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Emily Shaffer <emilyshaffer@google.com>
Cc: Joey S <jgsal@protonmail.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script
Date: Mon, 19 Oct 2020 18:59:24 -0700	[thread overview]
Message-ID: <xmqqpn5dd5dv.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201020001103.GB2774782@google.com> (Emily Shaffer's message of "Mon, 19 Oct 2020 17:11:03 -0700")

Emily Shaffer <emilyshaffer@google.com> writes:

> On Mon, Oct 19, 2020 at 04:26:07AM +0000, Joey S wrote:
>> 
>> Hi everyone,
> Hi Joey and welcome.
>
>> 
>> Signed-off-by: JoeyS <jgsal@yahoo.com>
>
> One thing missed by other commenters: the Developer's Certificate of
> Origin line - which is what this indicates - should have your "full
> name".

... and it must match the authorship.

> So in my case, I sign my patches 'Emily Shaffer
> <emilyshaffer@google.com>'. If I'm wrong that's fine, but JoeyS sounds
> like a name and initial rather than a full name.

Thanks for pointing it out.

If somebody from the "mentoring" group is taking a tally, it might
not be a bad idea to identify which style and procedure rules are
often failed to be followed by new contributors so that we can
figure out ways to make them stand out in our documentation set
(e.g. Documentation/SubmittingPatches but maybe a separate cheat
sheet might be worth having).

Thanks.



  reply	other threads:[~2020-10-20  1:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19  4:26 [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script Joey S
2020-10-19 11:28 ` Phillip Wood
2020-10-19 20:28   ` Taylor Blau
2020-10-20  0:11 ` Emily Shaffer
2020-10-20  1:59   ` Junio C Hamano [this message]
2020-10-20  7:24     ` Joey S
2020-10-20 12:19       ` Phillip Wood
2020-10-20 19:33         ` Joey S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpn5dd5dv.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=jgsal@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).