From: Junio C Hamano <gitster@pobox.com>
To: Josh Holland <anowlcalledjosh@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] userdiff: support Python async functions
Date: Mon, 11 Nov 2019 11:28:55 +0900 [thread overview]
Message-ID: <xmqqpnhzi1so.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191111010148.2812-1-anowlcalledjosh@gmail.com> (Josh Holland's message of "Mon, 11 Nov 2019 01:01:48 +0000")
Josh Holland <anowlcalledjosh@gmail.com> writes:
> Python's async functions (declared with "async def" rather than "def")
> were not being displayed in hunk headers. This commit teaches git about
> the async function syntax, and adds tests for the Python userdiff regex.
>
> Signed-off-by: Josh Holland <anowlcalledjosh@gmail.com>
> ---
> t/t4018/python-async-def | 4 ++++
> t/t4018/python-class | 4 ++++
> t/t4018/python-def | 4 ++++
> userdiff.c | 2 +-
> 4 files changed, 13 insertions(+), 1 deletion(-)
> create mode 100644 t/t4018/python-async-def
> create mode 100644 t/t4018/python-class
> create mode 100644 t/t4018/python-def
It seems that there were no test patterns for Python ;-) The change
to userdiff.c part (i.e. "where we used to expect 'def', we now
allow it to be prefixed with an optional 'async' plus whitespace")
makes sense.
Thanks, will queue.
next prev parent reply other threads:[~2019-11-11 2:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 1:01 [PATCH] userdiff: support Python async functions Josh Holland
2019-11-11 2:28 ` Junio C Hamano [this message]
2019-11-11 17:27 ` Johannes Sixt
2019-11-12 4:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpnhzi1so.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=anowlcalledjosh@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).