From: Junio C Hamano <gitster@pobox.com>
To: "Stephen P. Smith" <ischis2@cox.net>
Cc: git@vger.kernel.org,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff King" <peff@peff.net>,
"Philip Oakley" <philipoakley@iee.org>,
"Johannes Sixt" <j6t@kdbg.org>
Subject: Re: [PATCH v2 5/5] Add `human` date format tests.
Date: Fri, 18 Jan 2019 11:24:01 -0800 [thread overview]
Message-ID: <xmqqpnstkbvy.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190118061805.19086-6-ischis2@cox.net> (Stephen P. Smith's message of "Thu, 17 Jan 2019 23:18:05 -0700")
"Stephen P. Smith" <ischis2@cox.net> writes:
> +check_date_format() {
> + format=$1
> + t=$(($TEST_DATE_NOW - $2))
> + expect=$3
Notice that neither $format nor $1 is used in this test, which means
that "check_date_format" is not a generic "I can take a format
parameter to check the specified one". So perhaps
check_date_format_human () {
and then lose the first parameter?
> + test_expect_success "human date $t" "
> + echo $TEST_DATE_NOW >now &&
> + test-tool date human $t >actual &&
> + grep '$expect' actual
> +"
Hopefully $3 does not have a single quote in it ;-)
But the test block can see the shell variables just fine, so writing
it like the following is more in line with how the test framework is
designed to be used.
test_expect_success "human date $t" '
echo "$TEST_DATE_NOW" >now &&
test-tool date human "$t" >actual &&
grep "$expect" actual
'
How is the file 'now' get used? Nobody seems to read it around here.
Is the last one supposed to be "grep"? Or should we do
echo "$expect" >expect &&
test_cmp expect actual
instead?
> +}
> +
> +check_date_format human 18000 "5 hours ago" # 5 hours ago
> +check_date_format human 432000 "Tue Aug 25 19:20" # 5 days ago
> +check_date_format human 1728000 "Mon Aug 10 19:20" # 3 weeks ago
> +check_date_format human 13000000 "Thu Apr 2 08:13" # 5 months ago
> +check_date_format human 31449600 "Aug 31 2008" # 12 months ago
> +check_date_format human 37500000 "Jun 22 2008" # 1 year, 2 months ago
> +check_date_format human 55188000 "Dec 1 2007" # 1 year, 9 months ago
> +check_date_format human 630000000 "Sep 13 1989" # 20 years ago
> +
> test_done
next prev parent reply other threads:[~2019-01-18 19:24 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-31 0:31 [PATCH 0/3] Add 'human' date format Stephen P. Smith
2018-12-31 0:31 ` [PATCH 1/3] " Stephen P. Smith
2019-01-03 7:37 ` Jeff King
2019-01-03 13:19 ` Stephen P. Smith
2019-01-04 7:50 ` Jeff King
2019-01-04 13:03 ` Stephen P Smith
2019-01-06 6:19 ` Jeff King
2018-12-31 0:31 ` [PATCH 2/3] Add 'human' date format documentation Stephen P. Smith
2018-12-31 0:31 ` [PATCH 3/3] t0006-date.sh: add `human` date format tests Stephen P. Smith
2019-01-02 18:15 ` Junio C Hamano
2019-01-03 2:36 ` Stephen & Linda Smith
2019-01-03 6:42 ` Junio C Hamano
2019-01-03 13:20 ` Stephen P. Smith
2019-01-03 21:14 ` Philip Oakley
2019-01-03 21:45 ` Junio C Hamano
2019-01-03 23:57 ` Stephen P. Smith
2019-01-03 7:44 ` Jeff King
2019-01-03 13:12 ` Stephen & Linda Smith
2019-01-08 21:27 ` Johannes Sixt
2019-01-09 0:44 ` Stephen P. Smith
2019-01-09 6:58 ` Johannes Sixt
2019-01-10 1:50 ` Stephen & Linda Smith
2019-01-18 6:18 ` [PATCH v2 0/5] Re-roll of 'human' date format patch set Stephen P. Smith
2019-01-18 6:18 ` [PATCH v2 1/5] Add 'human' date format Stephen P. Smith
2019-01-18 6:18 ` [PATCH v2 2/5] Remove the proposed use of auto as secondary way to specify human Stephen P. Smith
2019-01-18 18:35 ` Junio C Hamano
2019-01-19 3:44 ` Stephen & Linda Smith
2019-01-18 6:18 ` [PATCH v2 3/5] Add 'human' date format documentation Stephen P. Smith
2019-01-18 18:47 ` Junio C Hamano
2019-01-18 6:18 ` [PATCH v2 4/5] Add `human` format to test-tool Stephen P. Smith
2019-01-18 19:03 ` Junio C Hamano
2019-01-20 22:11 ` Stephen P. Smith
2019-01-22 18:29 ` Junio C Hamano
2019-01-18 6:18 ` [PATCH v2 5/5] Add `human` date format tests Stephen P. Smith
2019-01-18 19:24 ` Junio C Hamano [this message]
2019-01-21 5:31 ` [PATCH v3 0/5] Re-roll of 'human' date format patch set Stephen P. Smith
2019-01-21 5:31 ` [PATCH v3 1/5] Add 'human' date format Stephen P. Smith
2019-01-21 5:31 ` [PATCH v3 2/5] Replace the proposed 'auto' mode with 'auto:' Stephen P. Smith
2019-01-21 5:31 ` [PATCH v3 3/5] Add 'human' date format documentation Stephen P. Smith
2019-01-21 5:31 ` [PATCH v3 4/5] Add `human` format to test-tool Stephen P. Smith
2019-01-22 22:34 ` Junio C Hamano
2019-01-21 5:31 ` [PATCH v3 5/5] Add `human` date format tests Stephen P. Smith
2019-01-29 3:50 ` [PATCH v4 0/5] Re-roll of 'human' date format patch set Stephen P. Smith
2019-01-29 3:50 ` [PATCH v4 1/5] Add 'human' date format Stephen P. Smith
2019-01-29 3:50 ` [PATCH v4 2/5] Replace the proposed 'auto' mode with 'auto:' Stephen P. Smith
2019-01-29 3:50 ` [PATCH v4 3/5] Add 'human' date format documentation Stephen P. Smith
2019-01-29 3:50 ` [PATCH v4 4/5] Add `human` format to test-tool Stephen P. Smith
2019-01-29 3:50 ` [PATCH v4 5/5] Add `human` date format tests Stephen P. Smith
2019-01-21 5:16 ` [PATCH v3 0/5] Re-roll of 'human' date format patch set Stephen P. Smith
2019-01-21 5:16 ` [PATCH v3 1/5] Add 'human' date format Stephen P. Smith
2019-01-21 5:16 ` [PATCH v3 2/5] Replace the proposed 'auto' mode with 'auto:' Stephen P. Smith
2019-01-21 5:16 ` [PATCH v3 3/5] Add 'human' date format documentation Stephen P. Smith
2019-01-21 5:16 ` [PATCH v3 4/5] Add `human` format to test-tool Stephen P. Smith
2019-01-21 5:16 ` [PATCH v3 5/5] Add `human` date format tests Stephen P. Smith
2019-01-21 15:04 ` SZEDER Gábor
2019-01-22 0:53 ` Stephen & Linda Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpnstkbvy.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=ischis2@cox.net \
--cc=j6t@kdbg.org \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).