git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "dorgon.chang" <dorgon.chang@gmail.com>
Cc: dorgonman@hotmail.com, git@vger.kernel.org, gitgitgadget@gmail.com
Subject: Re: [PATCH] git-p4: fix failed submit by skip non-text data files
Date: Mon, 21 Jun 2021 12:43:53 +0900	[thread overview]
Message-ID: <xmqqr1gvj30m.fsf@gitster.g> (raw)
In-Reply-To: 20210620075607.1228-1-dorgonman@hotmail.com

"dorgon.chang" <dorgon.chang@gmail.com> writes:

> The skip  will not affect actual submit files in the resulting cl,
> the diff line description will only appear in submit template, 
> so you can review what changed before actully submit to p4.
> ...
> I don't know if add any message here will be helpful for users, 
> so I choose to just skip binary content, since it already append filename previously. 

These are both good things to write in the proposed log message.

Thanks.

  reply	other threads:[~2021-06-21  3:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12  7:47 [PATCH] git-p4: fix failed submit by skip non-text data files dorgon chang via GitGitGadget
2021-06-17 11:18 ` Simon Hausmann
2021-06-18 13:24   ` Johannes Schindelin
2021-06-29  0:52     ` Junio C Hamano
2021-06-18 14:54 ` Simon Hausmann
2021-06-19  6:47 ` Junio C Hamano
2021-06-20  7:56   ` dorgon.chang
2021-06-21  3:43     ` Junio C Hamano [this message]
2021-06-21  5:16 ` [PATCH v2] " dorgon chang via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr1gvj30m.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dorgon.chang@gmail.com \
    --cc=dorgonman@hotmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).