git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Victor Engmark <victor@engmark.name>, git@vger.kernel.org
Subject: Re: [PATCH v3] userdiff: support Bash
Date: Thu, 22 Oct 2020 10:30:21 -0700	[thread overview]
Message-ID: <xmqqr1pqmamq.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <0d9f9ad1-2ba7-567e-97a1-a96f0b7cd4be@kdbg.org> (Johannes Sixt's message of "Thu, 22 Oct 2020 08:08:29 +0200")

Johannes Sixt <j6t@kdbg.org> writes:

> Am 22.10.20 um 01:45 schrieb Victor Engmark:
>> diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt
>> index 2d0a03715b..5e8a973449 100644
>> --- a/Documentation/gitattributes.txt
>> +++ b/Documentation/gitattributes.txt
>> @@ -802,6 +802,9 @@ patterns are available:
>>  
>>  - `ada` suitable for source code in the Ada language.
>>  
>> +- `bash` suitable for source code in the Bourne-Again SHell language.
>> +  Covers a superset of POSIX function definitions.
>
> OK. POSIX *shell* function definitions would have been even better, but
> I think I can live with this version.

I can't, so I'll locally amend ...

> This is very well done. Thank you!
>
> Acked-by: Johannes Sixt <j6t@kdbg.org>

... and with this in the trailer block.

Thanks, both.  Queued.

      reply	other threads:[~2020-10-22 17:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20  7:10 [PATCH] userdiff: support Bash Victor Engmark
2020-10-20 23:39 ` Junio C Hamano
2020-10-21  3:00   ` [PATCH v2] " Victor Engmark
2020-10-21  7:07     ` Johannes Sixt
2020-10-21 18:39       ` Junio C Hamano
2020-10-21 22:48       ` Victor Engmark
2020-10-21 23:45       ` [PATCH v3] " Victor Engmark
2020-10-22  6:08         ` Johannes Sixt
2020-10-22 17:30           ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr1pqmamq.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=victor@engmark.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).