From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
git <git@vger.kernel.org>,
"Pranit Bauva" <pranit.bauva@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH v2] bisect--helper: avoid segfault with bad syntax in `start --term-*`
Date: Sun, 24 May 2020 09:00:35 -0700 [thread overview]
Message-ID: <xmqqr1v9qq58.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAP8UFD1Oa6g4kj8GDhDC-3ry1eFyg-aD+JVDtfK1TkJKuL8v-Q@mail.gmail.com> (Christian Couder's message of "Fri, 22 May 2020 17:49:08 +0200")
Christian Couder <christian.couder@gmail.com> writes:
> On Thu, May 21, 2020 at 1:31 AM Carlo Marcelo Arenas Belón
> <carenas@gmail.com> wrote:
>>
>> 06f5608c14 (bisect--helper: `bisect_start` shell function partially in C,
>> 2019-01-02) adds a lax parser for `git bisect start` which could result
>> in a segfault under a bad syntax call for start with custom terms.
>>
>> Detect if there are enough arguments left in the command line to use for
>> --term-{old,good,new,bad} and abort with the same syntax error the original
>> implementation will show if not.
>>
>> While at it, remove an unnecessary (and incomplete) check for unknown
>> arguments and make sure to add a test to avoid regressions.
>
> This looks good to me!
Thanks, both.
prev parent reply other threads:[~2020-05-24 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 19:52 [PATCH] bisect--helper: avoid segfault with bad syntax in start --term-.+ Carlo Marcelo Arenas Belón
2020-05-20 20:20 ` Junio C Hamano
2020-05-20 22:25 ` Eric Sunshine
2020-05-20 23:26 ` [PATCH v2] bisect--helper: avoid segfault with bad syntax in `start --term-*` Carlo Marcelo Arenas Belón
2020-05-22 15:49 ` Christian Couder
2020-05-24 16:00 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr1v9qq58.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=carenas@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=pranit.bauva@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).