From: Junio C Hamano <gitster@pobox.com>
To: Dorab Patel <dorabpatel@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Git List <git@vger.kernel.org>,
Alexandre Julliard <julliard@winehq.org>
Subject: Re: [PATCH] git.el: handle default excludesfile properly
Date: Sun, 04 Mar 2018 18:36:37 -0800 [thread overview]
Message-ID: <xmqqr2oz9rka.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAE09B1+XXJvrOucHwehUGk=Taio7sirfOh5gq7KGs4iZSpK=vQ@mail.gmail.com> (Dorab Patel's message of "Sat, 3 Mar 2018 17:36:51 -0800")
Dorab Patel <dorabpatel@gmail.com> writes:
> Looking deeper into how the function git-get-exclude-files is used, I
> see that it is only being called from git-run-ls-files-with-excludes.
> So, perhaps, a better (or additional) fix might be to add the
> parameter "--exclude-standard" in the call to git-run-ls-files from
> within git-run-ls-files-with-excludes. And remove the need for
> get-get-exclude-files altogether.
It is absolutely the right thing to depend on --exclude-standard, I
would think, so that we do not have to worry about details like XDG
paths and such. Thanks for working that out between both of you.
Having said that, I am sorry to say that I am not sure if the copy
we have is the one to be patched, so I would appreciate if Alexandre
(cc'ed) can clarify the situation. The last change done to our copy
of the script is from 2012, and I do not know if Alexandre is still
taking care of it here but the script is so perfect that there was
no need to update it for the past 5 years and we haven't seen an
update, or the caninical copy is now being maintained elsewhere and
we only have a stale copy, or what.
Thanks.
next prev parent reply other threads:[~2018-03-05 2:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 3:48 [PATCH] git.el: handle default excludesfile properly Dorab Patel
2018-03-03 8:42 ` Eric Sunshine
2018-03-04 1:36 ` Dorab Patel
2018-03-04 2:12 ` Eric Sunshine
2018-03-04 2:57 ` Dorab Patel
2018-03-04 4:34 ` Eric Sunshine
2018-03-05 2:36 ` Junio C Hamano [this message]
2018-03-06 11:54 ` Alexandre Julliard
2018-03-07 21:52 ` Dorab Patel
2018-03-08 9:41 ` Ævar Arnfjörð Bjarmason
2018-03-08 9:45 ` [PATCH] git{,-blame}.el: remove old bitrotting Emacs code Ævar Arnfjörð Bjarmason
2018-03-08 17:27 ` Junio C Hamano
2018-03-10 12:30 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2018-03-10 16:50 ` Martin Ågren
2018-03-13 18:40 ` Junio C Hamano
2018-03-08 17:55 ` [PATCH] " Kyle Meyer
2018-03-06 4:38 ` [PATCH v2] git.el: handle default excludesfile properly Dorab Patel
[not found] <EKzyQbDEJGG4Lm5YboF8xg@mail.gmail.com>
2018-03-10 18:45 ` [PATCH v3] git{,-blame}.el: remove old bitrotting Emacs code Ævar Arnfjörð Bjarmason
2018-03-13 18:53 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2018-03-13 22:14 ` Junio C Hamano
2018-03-27 16:57 ` [PATCH v3] " Jonathan Nieder
2018-04-11 20:42 ` [PATCH v4] " Ævar Arnfjörð Bjarmason
2018-04-12 2:19 ` Junio C Hamano
2018-04-12 6:52 ` Ævar Arnfjörð Bjarmason
2018-04-12 9:23 ` Junio C Hamano
2018-04-18 20:16 ` Todd Zullinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr2oz9rka.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=dorabpatel@gmail.com \
--cc=git@vger.kernel.org \
--cc=julliard@winehq.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).