archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <>
To: ZheNing Hu <>
Cc: "René Scharfe" <>,
	"ZheNing Hu via GitGitGadget" <>,
	"Git List" <>, "Jeff King" <>,
	"Christian Couder" <>,
	"Hariom Verma" <>
Subject: Re: [PATCH] [GSOC] ref-filter: add %(notes) format atom
Date: Mon, 03 May 2021 11:56:59 +0900	[thread overview]
Message-ID: <xmqqsg34a5j8.fsf@gitster.g> (raw)
In-Reply-To: <> (ZheNing Hu's message of "Sun, 2 May 2021 14:12:09 +0800")

ZheNing Hu <> writes:

> Note that `cat-file --batch` should be a superset of `ref-filter` and
> `--pretty`, because
> it supports all objects, while `ref-filter` only supports "commit" and
> "tag" two kinds
> of objects, and `--pretty` only supports "commit" one kind of object.

What?  A ref can point at any kind of objects, not necessarily
commits and tags.  %(objectname), %(objecttype), etc. obviously
are applicable to any type of object.

Another thing worth noting is that ref-filter needs to deal with
traits that are not tied to any particular object, but to the ref
itself, like who its upstream is and where it would be pushed to.

> So it may be reasonable to provide `%(notes)` to "commit","tag"
> objects in `cat-file --batch`
> in the future, now integrate them into ref-filter firstly.

And you can attach notes to objects of any type, not limited to
commits and tags.

>> >     So in this patch, I tried to migrate --pretty=%N to --format=%(notes).

What do you mean by "migrate"?  Are you making both available?

>> > diff --git a/Documentation/git-for-each-ref.txt b/Documentation/git-for-each-ref.txt
>> > index 2ae2478de706..07f037a16e13 100644
>> > --- a/Documentation/git-for-each-ref.txt
>> > +++ b/Documentation/git-for-each-ref.txt
>> > @@ -139,6 +139,9 @@ deltabase::
>> >       given object, if it is stored as a delta.  Otherwise it
>> >       expands to the null object name (all zeroes).
>> >
>> > +notes::
>> > +     The notes associated with the ref.

"The notes associated with the object pointed at by the ref".

A note is never associated with a ref.  It can only associated with
an object.

If we are going to have %(notes), it may be natural to desire
grabbing notes for the given object from specified notes ref, e.g.

    git for-each-ref --format="%(notes:amlog) %(subject)" zh/pretty-date-human

may want to give the same kind of information as

    git show -s --format='%N %s' --notes=amlog zh/pretty-date-human

The underlying notes machinery however may not be prepared to work
with more than one notes tree at the same time, so

    git for-each-ref --format="%(notes) %(subject)" --notes=amlog zh/pretty-date-human

might be a better syntax, as --format="%(notes:X) %(notes:Y)" may
not be something you can easily support.

  reply	other threads:[~2021-05-03  2:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29 10:24 [PATCH] [GSOC] ref-filter: add %(notes) format atom ZheNing Hu via GitGitGadget
2021-05-01 19:21 ` René Scharfe
2021-05-02  6:12   ` ZheNing Hu
2021-05-03  2:56     ` Junio C Hamano [this message]
2021-05-03 13:25       ` ZheNing Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsg34a5j8.fsf@gitster.g \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).