From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Jason Pyeron <jpyeron@pdinc.us>, git@vger.kernel.org
Subject: Re: git archive setting user and group
Date: Fri, 22 Jan 2021 14:29:29 -0800 [thread overview]
Message-ID: <xmqqsg6s61x2.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <cef51cd3-c6b5-ed24-f695-83be3a6743b4@web.de> (=?utf-8?Q?=22R?= =?utf-8?Q?en=C3=A9?= Scharfe"'s message of "Fri, 22 Jan 2021 22:00:04 +0100")
René Scharfe <l.s.r@web.de> writes:
> Am 22.01.21 um 21:40 schrieb Jason Pyeron:
> ...
>> xsnprintf(header->uid, sizeof(header->uid), "%07o", 0);
>> xsnprintf(header->gid, sizeof(header->gid), "%07o", 0);
>> strlcpy(header->uname, "root", sizeof(header->uname));
>> strlcpy(header->gname, "root", sizeof(header->gname));
>
> Adding support for using a custom user and group should be easy. Is
> this just a cosmetic thing? Regular users would ignore the user info in
> the archive, and root should not be used for extracting, and on systems
> that don't have a logwatch user this wouldn't make a difference anyway,
> right?
I am not particularly interested in cosmetics, but it probably is OK
to make uname/gname overridable. I do not see any point in uid/gid
numeric values overridable, though. Just like user names and group
names do not name the same user and group on every machine, uid/gid
are even less so.
next prev parent reply other threads:[~2021-01-22 22:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 20:40 git archive setting user and group Jason Pyeron
2021-01-22 21:00 ` René Scharfe
2021-01-22 21:13 ` Jason Pyeron
2021-01-22 21:39 ` Konstantin Ryabitsev
2021-01-22 22:02 ` Jason Pyeron
2021-01-22 22:28 ` Ævar Arnfjörð Bjarmason
2021-01-23 1:05 ` brian m. carlson
2021-01-23 4:58 ` Jeff King
2021-01-23 5:16 ` Konstantin Ryabitsev
2021-01-23 5:11 ` Konstantin Ryabitsev
2021-01-22 22:29 ` Junio C Hamano [this message]
2021-01-22 22:51 ` Jason Pyeron
-- strict thread matches above, loose matches on Subject: below --
2021-01-22 20:09 Jason Pyeron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsg6s61x2.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jpyeron@pdinc.us \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).