From: Junio C Hamano <gitster@pobox.com>
To: Emily Shaffer <emilyshaffer@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] bugreport: collect list of populated hooks
Date: Fri, 24 Apr 2020 21:52:07 -0700 [thread overview]
Message-ID: <xmqqsggs9ngo.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200424233800.200439-1-emilyshaffer@google.com> (Emily Shaffer's message of "Fri, 24 Apr 2020 16:38:00 -0700")
Emily Shaffer <emilyshaffer@google.com> writes:
> Without a definitive list of hook names within the code, we compile our
> own list from the documentation. This is likely prone to bitrot. To
> reduce the amount of code humans need to read, we turn the list into a
> string_list and iterate over it (as we are calling the same find_hook
> operation on each string). However, since bugreport should primarily be
> called by the user, the performance loss from massaging the string
> seems acceptable.
In this iteration we no longer are collecting the hook names into
string list, but just formating the findings in a strbuf, no?
> @@ -33,6 +35,53 @@ static void get_system_info(struct strbuf *sys_info)
> get_libc_info(sys_info);
> }
>
> +static void get_populated_hooks(struct strbuf *hook_info, int nongit)
> +{
> + /*
> + * NEEDSWORK: Doesn't look like there is a list of all possible hooks;
> + * so below is a transcription of `git help hooks`. Later, this should
> + * be replaced with some programmatically generated list (generated from
> + * doc or else taken from some library which tells us about all the
> + * hooks)
> + */
Yes, I recall that we discussed adding some annotation to
documentation and extracting this automatically.
> + const char *hook[] = {
Is it worth making this "static const"?
> + if (nongit) {
> + strbuf_addstr(hook_info,
> + "not run from a git repository - no hooks to show\n");
> + return;
> + }
> +
> + for (i=0; i < ARRAY_SIZE(hook); i++)
Style: SP around = in "i=0".
> + get_header(&buffer, "Enabled Hooks");
> + get_populated_hooks(&buffer, nongit_ok);
> +
Sounds good, otherwise.
next prev parent reply other threads:[~2020-04-25 4:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 23:38 [PATCH] bugreport: collect list of populated hooks Emily Shaffer
2020-04-25 0:30 ` Jonathan Nieder
2020-04-27 20:48 ` [PATCH] bugreport: drop time.h include Emily Shaffer
2020-04-27 21:03 ` Jonathan Nieder
2020-04-27 21:25 ` Junio C Hamano
2020-04-27 21:41 ` Junio C Hamano
2020-04-27 21:56 ` Emily Shaffer
2020-04-27 23:27 ` Junio C Hamano
2020-04-27 23:42 ` [PATCH v2] bugreport: drop extraneous includes Emily Shaffer
2020-04-27 23:46 ` Jonathan Nieder
2020-04-25 4:52 ` Junio C Hamano [this message]
2020-04-27 19:02 ` [PATCH] bugreport: collect list of populated hooks Emily Shaffer
2020-04-27 20:46 ` Junio C Hamano
2020-04-27 20:49 ` Emily Shaffer
2020-04-27 23:38 ` [PATCH v2] " Emily Shaffer
2020-04-27 23:45 ` Jonathan Nieder
2020-04-28 0:04 ` Junio C Hamano
2020-04-30 0:01 ` Emily Shaffer
2020-04-30 1:24 ` [PATCH v3] " Emily Shaffer
2020-04-30 1:50 ` Jonathan Nieder
2020-04-30 1:53 ` Jonathan Nieder
2020-04-30 17:44 ` Junio C Hamano
2020-04-30 22:09 ` Junio C Hamano
2020-05-07 21:08 ` Emily Shaffer
2020-05-07 23:06 ` Junio C Hamano
2020-05-11 21:26 ` Emily Shaffer
2020-05-08 0:53 ` [PATCH v4] " Emily Shaffer
2020-05-08 1:20 ` Junio C Hamano
2020-05-08 1:34 ` Đoàn Trần Công Danh
2020-05-11 21:22 ` Emily Shaffer
2020-05-11 22:14 ` [PATCH v5] " Emily Shaffer
2020-05-11 23:26 ` Jonathan Nieder
2020-05-11 23:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsggs9ngo.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).