git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "CHIGOT\, CLEMENT" <clement.chigot@atos.net>,
	"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] git-compat-util: work around for access(X_OK) under root
Date: Wed, 24 Apr 2019 09:55:04 +0900	[thread overview]
Message-ID: <xmqqsgu843yv.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190423235526.GF6316@genre.crustytoothpaste.net> (brian m. carlson's message of "Tue, 23 Apr 2019 23:55:26 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> What POSIX says on this is the following:
>
>   If any access permissions are checked, each shall be checked
>   individually, as described in XBD File Access Permissions, except that
>   where that description refers to execute permission for a process with
>   appropriate privileges, an implementation may indicate success for
>   X_OK even if execute permission is not granted to any user.

Do I take this "not granted to any user" as "no +x bit is set for
owner, group or other", and "a process with appropriate privileges"
as "running as root"?

The latter half feels iffy, if the system is still allowed to fail
execution by "a process with appropriate privileges", leading to
inconsistent answer from access(2) and behaviour by execv(2).  But
at least that explains what was observed.

> I believe that's what's occurring here. Your commit message, however,
> should contain some text that explains that AIX takes this liberty
> provided by POSIX, and why that causes problems for Git (i.e., what
> problems the user will see). Ideally, the reader of the commit message
> will know the relevant details about this issue from your commit message
> without needing to consult the standard itself.

Very true.

Thanks.

  reply	other threads:[~2019-04-24  0:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23  8:38 [PATCH] git-compat-util: work around for access(X_OK) under root CHIGOT, CLEMENT
2019-04-23 10:11 ` Duy Nguyen
2019-04-23 10:32 ` Junio C Hamano
2019-04-23 11:31   ` CHIGOT, CLEMENT
2019-04-23 23:55     ` brian m. carlson
2019-04-24  0:55       ` Junio C Hamano [this message]
2019-04-24  1:16         ` brian m. carlson
2019-04-24  0:48     ` Junio C Hamano
2019-04-24  7:54       ` CHIGOT, CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsgu843yv.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=clement.chigot@atos.net \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).