From: Junio C Hamano <gitster@pobox.com>
To: Tim Schumacher <timschumi@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH] Allow aliases that include other aliases
Date: Tue, 04 Sep 2018 10:55:35 -0700 [thread overview]
Message-ID: <xmqqsh2p9mg8.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180904173915.2393-1-timschumi@gmx.de> (Tim Schumacher's message of "Tue, 4 Sep 2018 19:39:15 +0200")
Tim Schumacher <timschumi@gmx.de> writes:
> I submitted this as RFC because I'm not sure whether disallowing
> nested aliases was an intentional design choice. The done_alias
> check implies that disallowing is intended, but the direct
> recursion check for aliases that call themselves opposes that.
"direct recursion check for aliases"? I am not sure what you mean
by that, but anyway.
If I recall correctly, it is intended that we disallow run_argv()
doing handle_alias() twice (or more). But the ultimate objective is
to forbid infinite loops, "git foo" expanding to "git bar" which in
turn expanding back to "git foo", and the current "do not expand
alias to another" is a simple but too strict implementation. As
long as a replacement implementation still forbids infinite loops
with reasonable cost and complexity, I do not think we would mind
such an improvement to allow alias expanding to another alias.
next prev parent reply other threads:[~2018-09-04 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 17:39 [RFC PATCH] Allow aliases that include other aliases Tim Schumacher
2018-09-04 17:55 ` Junio C Hamano [this message]
2018-09-04 20:11 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsh2p9mg8.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=timschumi@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).