From: Junio C Hamano <gitster@pobox.com>
To: "Raghul Nanth A via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Derrick Stolee <derrickstolee@github.com>,
Victoria Dye <vdye@github.com>,
Raghul Nanth A <nanth.raghul@gmail.com>
Subject: Re: [PATCH v3] describe: enable sparse index for describe
Date: Thu, 30 Mar 2023 08:13:02 -0700 [thread overview]
Message-ID: <xmqqtty22ry9.fsf@gitster.g> (raw)
In-Reply-To: <xmqq1ql64796.fsf@gitster.g> (Junio C. Hamano's message of "Thu, 30 Mar 2023 07:57:09 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> "Raghul Nanth A via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: Raghul Nanth A <nanth.raghul@gmail.com>
>>
>> Add usage and performance tests for describe
>
> I think this sentence can easily go.
>
>> Describe uses the index when it is run with --dirty flag, which uses the
>> run_diff_index commmand. The command is sparse-index aware and hence we
>> can just set the requires-full-index to false
>
> End the sentence with full-stop. More importantly, it would be
> nicer to have something to substantiate the "this is sparse aware"
> claim here, something like "since commit X" or "as shown in the test
> tXXXX.YY".
With a bit of digging into the history, I think the topic that was
merged at 8d2c3732 (Merge branch 'ld/sparse-diff-blame', 2021-12-21)
made various modes of "git diff" to be sparse-index aware. t1092
has tests for "git diff --cached", which uses the same machinery.
Subject: [PATCH] describe: make it sparse-index aware
"git describe" needs to compare the index and the working tree
when (and only when) it is run with the "--dirty" flag. This is
done by calling the run_diff_index() function, which has been
already made aware of the sparse-index in the series that led to
8d2c3732 (Merge branch 'ld/sparse-diff-blame', 2021-12-21).
t1092 has tests for "git diff --cached", which uses this exact
machinery.
Mark "git describe" that the command does not require the index
to be expanded fully beforehand.
or something like that.
> Updated tests do look good, and the code change is of course minimal
> and to the point, which is also good.
Thanks.
next prev parent reply other threads:[~2023-03-30 15:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 14:20 [PATCH] describe: enable sparse index for describe Raghul Nanth A via GitGitGadget
2023-03-27 18:26 ` Junio C Hamano
2023-03-28 19:46 ` Derrick Stolee
2023-03-28 20:24 ` Junio C Hamano
2023-03-28 20:35 ` Derrick Stolee
2023-03-29 16:25 ` [PATCH v2] " Raghul Nanth A via GitGitGadget
2023-03-29 17:00 ` Junio C Hamano
2023-03-29 17:49 ` Victoria Dye
2023-03-29 18:27 ` Junio C Hamano
2023-03-30 16:10 ` Raghul Nanth
2023-04-03 16:37 ` Victoria Dye
2023-03-30 5:59 ` [PATCH v3] " Raghul Nanth A via GitGitGadget
2023-03-30 14:57 ` Junio C Hamano
2023-03-30 15:13 ` Junio C Hamano [this message]
2023-03-30 16:23 ` Victoria Dye
2023-03-31 15:43 ` [GSOC][PATCH] " Raghul Nanth A
2023-03-31 16:34 ` Junio C Hamano
2023-03-31 18:20 ` [GSOC][PATCH v4] " Raghul Nanth A
2023-04-03 16:34 ` Victoria Dye
2023-04-03 16:47 ` [GSOC][PATCH v5] " Raghul Nanth A
2023-04-03 7:35 ` [PATCH v4] " Raghul Nanth A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtty22ry9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=nanth.raghul@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).