From: Junio C Hamano <gitster@pobox.com>
To: David Turner <dturner@twosigma.com>
Cc: git@vger.kernel.org, novalis@novalis.org
Subject: Re: [PATCH v4 1/3] Remove unused var
Date: Tue, 31 Aug 2021 10:16:34 -0700 [thread overview]
Message-ID: <xmqqtuj5v8jx.fsf@gitster.g> (raw)
In-Reply-To: 20210831131257.1631316-1-dturner@twosigma.com
David Turner <dturner@twosigma.com> writes:
> Signed-off-by: David Turner <dturner@twosigma.com>
> ---
> t/t4060-diff-submodule-option-diff-format.sh | 1 -
> 1 file changed, 1 deletion(-)
Of course this still makes sense ;-)
Let me retitle it to "t4060: remove unused variable" to help readers
of "git shortlog --no-merges", though, while queuing.
Other two patches looked sensible to me, but I'd welcome comments by
submodule users, of course ;-)
Thanks.
> diff --git a/t/t4060-diff-submodule-option-diff-format.sh b/t/t4060-diff-submodule-option-diff-format.sh
> index dc7b242697..69b9946931 100755
> --- a/t/t4060-diff-submodule-option-diff-format.sh
> +++ b/t/t4060-diff-submodule-option-diff-format.sh
> @@ -361,7 +361,6 @@ test_expect_success 'typechanged submodule(submodule->blob)' '
> rm -f sm1 &&
> test_create_repo sm1 &&
> head6=$(add_file sm1 foo6 foo7)
> -fullhead6=$(cd sm1; git rev-parse --verify HEAD)
> test_expect_success 'nonexistent commit' '
> git diff-index -p --submodule=diff HEAD >actual &&
> cat >expected <<-EOF &&
next prev parent reply other threads:[~2021-08-31 17:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 18:33 [PATCH 1/3] Remove unused var David Turner
2021-07-26 18:33 ` [PATCH 2/3] diff --submodule=diff: do not fail on ever-initialied deleted submodules David Turner
2021-07-26 22:57 ` Junio C Hamano
2021-07-27 17:35 ` David Turner
2021-08-31 6:17 ` Junio C Hamano
2021-08-31 13:12 ` [PATCH v4 1/3] Remove unused var David Turner
2021-08-31 13:12 ` [PATCH v4 2/3] diff --submodule=diff: do not fail on ever-initialied deleted submodules David Turner
2021-08-31 13:12 ` [PATCH v4 3/3] diff --submodule=diff: Don't print failure message twice David Turner
2021-08-31 17:16 ` Junio C Hamano [this message]
2021-07-26 18:33 ` [PATCH " David Turner
2021-07-26 22:47 ` Junio C Hamano
2021-07-26 22:47 ` [PATCH 1/3] Remove unused var Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtuj5v8jx.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dturner@twosigma.com \
--cc=git@vger.kernel.org \
--cc=novalis@novalis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).