From: Junio C Hamano <gitster@pobox.com>
To: "Drew DeVault" <sir@cmpwn.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 2/3] git-send-email: die on invalid smtp_encryption
Date: Tue, 13 Apr 2021 14:39:43 -0700 [thread overview]
Message-ID: <xmqqtuo9kgo0.fsf@gitster.g> (raw)
In-Reply-To: <CAML4RYHKQ6U.35902JHAIZYY@taiga> (Drew DeVault's message of "Tue, 13 Apr 2021 08:12:47 -0400")
"Drew DeVault" <sir@cmpwn.com> writes:
> Can I get one of the maintainers to chime in on this thread and explain,
> in their opinion, what this patchset needs before it is acceptable? I'm
> not sure where I should go from this discussion.
What you called "compromise" in the upthread didn't even smelled
like a compromise but the safest way forward. My reasoning goes
(thinking aloud, so that you and Ævar can correct me if I am talking
nonsense and discount my input based on it):
- If we were designing this from scratch, we would have called the
smtps:// tunnelled transport SSL/TLS and in-place upgrade
transport STARTTLS, like e-mail providers and client programs do,
but unfortunately we didn't. We ended up with 'ssl' vs 'tls'.
- We could introduce and advertise STARTTLS as a synonym to 'tls',
but then those whose send-email does not understand STARTTLS but
read about the new way of spelling would end up having no
encryption due to another earlier mistake we made, i.e. an
unrecognised option value silently turns into no encryption.
- To avoid the above problem, the first phase is not to change the
status quo that 'ssl' vs 'tls' are the only two choices. What we
do is to make the program error out if we see an unrecognised
value given to the option. We release this to the wild, and wait
for the current versions of send-email that turns unrecognised
words into no-encryption die out. It may take several years,
though.
- After waiting, we add 'starttls' as a synonym to 'tls'. We may
also add 'ssl/tls' as a synonym to 'ssl'. Unfortunately 'tls'
alone cannot be repurposed as a synonym for smtps:// without
another deprecation dance, and it is not in scope of the
transtion.
Am I on the same page as you two?
next prev parent reply other threads:[~2021-04-13 21:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-11 12:54 [PATCH v2 0/3] git-send-email: improve SSL configuration Drew DeVault
2021-04-11 12:54 ` [PATCH v2 1/3] git-send-email(1): improve smtp-encryption docs Drew DeVault
2021-04-11 14:11 ` Ævar Arnfjörð Bjarmason
2021-04-11 12:54 ` [PATCH v2 2/3] git-send-email: die on invalid smtp_encryption Drew DeVault
2021-04-11 14:20 ` Ævar Arnfjörð Bjarmason
2021-04-11 14:21 ` Drew DeVault
2021-04-11 14:30 ` Ævar Arnfjörð Bjarmason
2021-04-11 15:06 ` Ævar Arnfjörð Bjarmason
2021-04-11 15:18 ` Drew DeVault
2021-04-11 19:56 ` Ævar Arnfjörð Bjarmason
2021-04-12 12:33 ` Drew DeVault
2021-04-12 13:16 ` Ævar Arnfjörð Bjarmason
2021-04-13 12:12 ` Drew DeVault
2021-04-13 14:22 ` Ævar Arnfjörð Bjarmason
2021-04-13 21:39 ` Junio C Hamano [this message]
2021-04-11 12:54 ` [PATCH v2 3/3] git-send-email: rename 'tls' to 'starttls' Drew DeVault
2021-04-11 14:17 ` Ævar Arnfjörð Bjarmason
2021-04-11 14:22 ` Drew DeVault
2021-04-11 14:43 ` [PATCH 0/2] send-email: simplify smtp.{smtpssl,smtpencryption} parsing Ævar Arnfjörð Bjarmason
2021-04-11 14:43 ` [PATCH 1/2] send-email: remove non-working support for "sendemail.smtpssl" Ævar Arnfjörð Bjarmason
2021-04-11 19:08 ` Junio C Hamano
2021-04-11 19:51 ` Ævar Arnfjörð Bjarmason
2021-05-01 9:15 ` Ævar Arnfjörð Bjarmason
2021-04-11 14:43 ` [PATCH 2/2] send-email: refactor sendemail.smtpencryption config parsing Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtuo9kgo0.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=sir@cmpwn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).