From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Sean McAllister <smcallis@google.com>,
git@vger.kernel.org, peff@peff.net, masayasuzuki@google.com
Subject: Re: [PATCH 3/3] http: automatically retry some requests
Date: Mon, 12 Oct 2020 14:00:34 -0700 [thread overview]
Message-ID: <xmqqtuuzma6l.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2010122126280.50@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Mon, 12 Oct 2020 22:15:38 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi Sean,
>
> On Mon, 12 Oct 2020, Sean McAllister wrote:
>
>> Some HTTP response codes indicate a server state that can support
>> retrying the request rather than immediately erroring out. The server
>> can also provide information about how long to wait before retries to
>> via the Retry-After header. So check the server response and retry
>> some reasonable number of times before erroring out to better accomodate
>> transient errors.
>>
>> Exiting immediately becomes irksome when pulling large multi-repo code
>> bases such as Android or Chromium, as often the entire fetch operation
>> has to be restarted from the beginning due to an error in one repo. If
>> we can reduce how often that occurs, then it's a big win.
>
> Makes a lot of sense to me.
> ...
>> +http.retryLimit::
>> + Some HTTP error codes (eg: 429,503) can reasonably be retried if
>
> Please have a space after the comma so that it is not being mistaken for a
> 6-digit number. Also, aren't they called "status codes"? Not all of them
> indicate errors, after all.
> ...
I've read your comments and agree to them all. Thanks for a
detailed and excellent review.
next prev parent reply other threads:[~2020-10-12 21:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201012184806.166251-1-smcallis@google.com>
2020-10-12 18:48 ` [PATCH 2/3] replace CURLOPT_FILE With CURLOPT_WRITEDATA Sean McAllister
2020-10-12 19:26 ` Johannes Schindelin
2020-10-12 18:48 ` [PATCH 3/3] http: automatically retry some requests Sean McAllister
2020-10-12 20:15 ` Johannes Schindelin
2020-10-12 21:00 ` Junio C Hamano [this message]
2020-10-13 15:03 ` Sean McAllister
2020-10-13 17:45 ` Junio C Hamano
2020-10-12 20:19 ` [PATCH] remote-curl: add testing for intelligent retry for HTTP Sean McAllister
2020-10-12 20:51 ` Junio C Hamano
2020-10-12 22:20 ` Sean McAllister
2020-10-12 22:30 ` Junio C Hamano
2020-10-13 14:25 ` Johannes Schindelin
2020-10-13 17:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtuuzma6l.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=masayasuzuki@google.com \
--cc=peff@peff.net \
--cc=smcallis@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).