From: Junio C Hamano <gitster@pobox.com>
To: Abhishek Kumar <abhishekkumar8222@gmail.com>
Cc: git@vger.kernel.org, stolee@gmail.com, jnareb@gmail.com
Subject: Re: [PATCH v3 1/4] alloc: introduce parsed_commits_count
Date: Fri, 12 Jun 2020 13:08:04 -0700 [thread overview]
Message-ID: <xmqqtuzg11zv.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200612184014.1226972-2-abhishekkumar8222@gmail.com> (Abhishek Kumar's message of "Sat, 13 Jun 2020 00:10:11 +0530")
Abhishek Kumar <abhishekkumar8222@gmail.com> writes:
> static unsigned int alloc_commit_index(struct repository *r)
> {
> - return r->parsed_objects->commit_count++;
> + static unsigned int parsed_commits_count = 0;
> + r->parsed_objects->commit_count++;
> + return parsed_commits_count++;
> }
Hmph, ugly.
The need for this hack, which butchers the function that explicitly
takes a repository as its parameter so that parsed commits can be
counted per repository to not count commits per repository, makes
the whole thing smell fishy.
There shouldn't be a reason why a commit in the superproject and
another commit in the submodule need to be in the same commit graph
in the first place.
Instead of breaking the function like this, the right "fix" may be
to make the commit slab per repository, because the commit index are
taken from the separate namespace per repository.
next prev parent reply other threads:[~2020-06-12 20:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 18:40 [GSoC Patch v3 0/4] Move generation, graph_pos to a slab Abhishek Kumar
2020-06-12 18:40 ` [PATCH v3 1/4] alloc: introduce parsed_commits_count Abhishek Kumar
2020-06-12 20:08 ` Junio C Hamano [this message]
2020-06-12 22:00 ` Junio C Hamano
2020-06-12 22:20 ` Junio C Hamano
2020-06-12 22:52 ` Junio C Hamano
2020-06-13 18:57 ` Abhishek Kumar
2020-06-12 23:16 ` Jakub Narębski
2020-06-12 18:40 ` [PATCH v3 2/4] commit-graph: introduce commit_graph_data_slab Abhishek Kumar
2020-06-13 6:53 ` SZEDER Gábor
2020-06-17 9:18 ` Abhishek Kumar
2020-06-12 18:40 ` [PATCH v3 3/4] commit: move members graph_pos, generation to a slab Abhishek Kumar
2020-06-12 18:40 ` [PATCH v3 4/4] commit-graph: minimize commit_graph_data_slab access Abhishek Kumar
2020-06-12 21:26 ` [GSoC Patch v3 0/4] Move generation, graph_pos to a slab Jakub Narębski
2020-06-14 6:09 [PATCH v3 1/4] alloc: introduce parsed_commits_count Abhishek Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtuzg11zv.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=abhishekkumar8222@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).