Re: [PATCH v3 1/1] midx.c: fix an integer overflow

From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Damien Robert <damien.olivier.robert@gmail.com>,
	git@vger.kernel.org, Derrick Stolee <dstolee@microsoft.com>,
	William Baker <William.Baker@microsoft.com>,
	Damien Robert <damien.olivier.robert+git@gmail.com>
Subject: Re: [PATCH v3 1/1] midx.c: fix an integer overflow
Date: Tue, 24 Mar 2020 11:48:55 -0700	[thread overview]
Message-ID: <xmqqtv2d1td4.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200324060125.GA610977@coredump.intra.peff.net> (Jeff King's message of "Tue, 24 Mar 2020 02:01:25 -0400")

Jeff King <peff@peff.net> writes:

> I'd be OK with just this, but adding a binary t/t5319/zero-objs.midx
> would be fine by me, too.

Yup, that sounds like a simple way to make sure we won't regress.

> One minor style nit:
>
>> @@ -1124,6 +1130,13 @@ int verify_midx_file(struct repository *r, const char *object_dir, unsigned flag
>>  				    i, oid_fanout1, oid_fanout2, i + 1);
>>  	}
>>  
>> +	if (m->num_objects == 0) {
>> +		midx_report(_("the midx contains no oid"));
>> +		// remaining tests assume that we have objects, so we can
>> +		// return here
>> +		return verify_midx_error;
>> +	}
>
> We prefer /**/ for comments, like:
>
>   /*
>    * Remaining tests assume that we have objects, so we can
>    * return here.
>    */

Thanks for catching it.