git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>, Danh Doan <congdanhqx@gmail.com>
Subject: Re: [PATCH v3] submodule: teach set-url subcommand
Date: Wed, 30 Oct 2019 14:54:58 +0900	[thread overview]
Message-ID: <xmqqtv7q3hhp.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <f5f44812af2b43fe3f7ea837f8b07c4747eedcc0.1572368447.git.liu.denton@gmail.com> (Denton Liu's message of "Tue, 29 Oct 2019 10:01:52 -0700")

Denton Liu <liu.denton@gmail.com> writes:

> Currently, in the event that a submodule's upstream URL changes, users
> have to manually alter the URL in the .gitmodules file then run
> `git submodule sync`. Let's make that process easier.

Right now, submodule.<name>.url might be the only thing that gets
synched down to .git/config of the submodule; we may not learn any
more things that needs "edit in .gitmodules and then run sync".  Can
we sately say that "sync" is now obsolete and what it has been used
for can now be done with "set-url"?  In other words, does "set-url"
makes "sync" unnecessary and deprecated?

Or is it expected that we would learn more things end users can edit
in .gitmodules and run sync to propagate necessary pieces of
information down?  If so, do we want to add an extra command like
set-url for each of these new things, or do we tell users "if you
are editing url, use set-url, otherwise edit .gitmodules and run
sync"?  If the former, that would make the set of subcommands quite
noisy, and if the latter, the users need to learn two things,
i.e. it is not making it easier but harder to learn the system.

There is nothing _wrong_ to introduce the new subcommand per-se, but
given that the URL should not change that often, and due to above
concerns, I am not sure if I want to back this change.

  reply	other threads:[~2019-10-30  5:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17 20:03 [PATCH] " Denton Liu
2019-10-29  8:34 ` [PATCH v2] " Denton Liu
2019-10-29  9:15   ` Danh Doan
2019-10-29 17:01   ` [PATCH v3] " Denton Liu
2019-10-30  5:54     ` Junio C Hamano [this message]
2019-10-30 17:58       ` Denton Liu
2019-11-02  4:25         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtv7q3hhp.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=congdanhqx@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=liu.denton@gmail.com \
    --subject='Re: [PATCH v3] submodule: teach set-url subcommand' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).