From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Chris Packham <judge.packham@gmail.com>, GIT <git@vger.kernel.org>
Subject: Re: Error when cloning with weird local directory
Date: Thu, 06 Aug 2015 00:44:09 -0700 [thread overview]
Message-ID: <xmqqtwsczws6.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <55C2F54A.7070702@web.de> ("Torsten =?utf-8?Q?B=C3=B6gershaus?= =?utf-8?Q?en=22's?= message of "Thu, 6 Aug 2015 07:48:58 +0200")
Torsten Bögershausen <tboegi@web.de> writes:
> It looks as if
> static char *get_repo_path(const char *repo, int *is_bundle)
> in built/clone.c
> checks if there is a local directory structure looking like a
> .git directory.
> This is wrong.
It is as designed, though, to allow cloning from a local directory
with any name.
> There should be a check for the scheme first.
That will be wrong.
next prev parent reply other threads:[~2015-08-06 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 4:21 Error when cloning with weird local directory Chris Packham
2015-08-06 5:48 ` Torsten Bögershausen
2015-08-06 7:44 ` Junio C Hamano [this message]
2015-08-06 7:50 ` Junio C Hamano
2015-08-08 6:26 ` Torsten Bögershausen
2015-08-10 18:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwsczws6.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=judge.packham@gmail.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).