git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
	Max Horn <max@quendi.de>,
	git@vger.kernel.org
Subject: Re: My patches
Date: Fri, 18 Oct 2013 09:59:41 -0700	[thread overview]
Message-ID: <xmqqtxgewm4i.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20131018153009.GA23704@thunk.org> (Theodore Ts'o's message of "Fri, 18 Oct 2013 11:30:09 -0400")

Theodore Ts'o <tytso@mit.edu> writes:

> Over the past 5+ years, I've observed that I
> think the way commit selection in "git format-patch" is inconsistent
> with how we handle commit selection for other commands, e.g., "git log
> <commit>" vs and "git format-patch <commit>".  Even if you think that
> this is a matter of self-inherent "truth", versus just a matter of
> taste, there is also the consideration of backwards compatibility, and
> the question of how important consistency and easy of learning gets
> traded off against backwards compatibility and invalidating
> potentially huge numbers of shell scripts and documentation.  So it's
> not something where I've made a nuisance of myself, because it's a
> settled issue.

The original syntax to select of commits by format-patch is very
inconsistent from the log family because it was done way before the
log family's way has been established as the best practice. It has
annoyed enough people that we spent effort to teach recent Git
to accept

	$ git format-patch master..next

as well.

So it indeed is a settled issue, but you are correct to point out
that we had to find a way to do so while still keeping the original
syntax working for people who have scripts and people who work from
random and stale documents we have not much control over updating.

      parent reply	other threads:[~2013-10-18 16:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-12  7:24 My patches Felipe Contreras
2013-10-12 16:18 ` Philip Oakley
2013-10-12 22:33   ` Felipe Contreras
2013-10-14 17:42 ` Junio C Hamano
2013-10-14 21:40   ` Felipe Contreras
2013-10-17 19:54     ` Junio C Hamano
2013-10-17 21:44       ` Felipe Contreras
2013-10-18 11:21         ` Max Horn
2013-10-18 11:41           ` Felipe Contreras
2013-10-18 15:30             ` Theodore Ts'o
2013-10-18 15:49               ` Felipe Contreras
2013-10-18 16:59               ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtxgewm4i.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=max@quendi.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).